* [Qemu-devel] [PATCH] cpu-exec: Remove relic orphaned comment
@ 2016-05-03 14:34 Sergey Fedorov
2016-05-03 14:36 ` Sergey Fedorov
0 siblings, 1 reply; 3+ messages in thread
From: Sergey Fedorov @ 2016-05-03 14:34 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, Sergey Fedorov, Sergey Fedorov, Paolo Bonzini,
Peter Crosthwaite, Richard Henderson
From: Sergey Fedorov <serge.fdrv@gmail.com>
This comment should have been deleted by commit 0ac087f1f3ae ("removed
unused code") but somehow it is still here. There's no point to keep it.
Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Sergey Fedorov <serge.fedorov@linaro.org>
---
cpu-exec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index d43d5ae729b6..d55faa5114c7 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -582,8 +582,6 @@ int cpu_exec(CPUState *cpu)
/* Try to align the host and virtual clocks
if the guest is in advance */
align_clocks(&sc, cpu);
- /* reset soft MMU for next block (it can currently
- only be set by a memory fault) */
} /* for(;;) */
} else {
#if defined(__clang__) || !QEMU_GNUC_PREREQ(4, 6)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] cpu-exec: Remove relic orphaned comment
2016-05-03 14:34 [Qemu-devel] [PATCH] cpu-exec: Remove relic orphaned comment Sergey Fedorov
@ 2016-05-03 14:36 ` Sergey Fedorov
2016-05-04 17:56 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Sergey Fedorov @ 2016-05-03 14:36 UTC (permalink / raw)
To: Sergey Fedorov, qemu-devel
Cc: Alex Bennée, Sergey Fedorov, Paolo Bonzini,
Peter Crosthwaite, Richard Henderson
On 03/05/16 17:34, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> This comment should have been deleted by commit 0ac087f1f3ae ("removed
> unused code") but somehow it is still here. There's no point to keep it.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <serge.fedorov@linaro.org>
Sorry, should be:
Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Also, this patch is based on a commit:
3c712db2c10b ("cpu-exec: Move TB chaining into tb_find_fast()")
from:
git://github.com/rth7680/qemu.git tcg-next
Kind regards,
Sergey
> ---
> cpu-exec.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index d43d5ae729b6..d55faa5114c7 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -582,8 +582,6 @@ int cpu_exec(CPUState *cpu)
> /* Try to align the host and virtual clocks
> if the guest is in advance */
> align_clocks(&sc, cpu);
> - /* reset soft MMU for next block (it can currently
> - only be set by a memory fault) */
> } /* for(;;) */
> } else {
> #if defined(__clang__) || !QEMU_GNUC_PREREQ(4, 6)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] cpu-exec: Remove relic orphaned comment
2016-05-03 14:36 ` Sergey Fedorov
@ 2016-05-04 17:56 ` Richard Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2016-05-04 17:56 UTC (permalink / raw)
To: Sergey Fedorov, Sergey Fedorov, qemu-devel
Cc: Sergey Fedorov, Paolo Bonzini, Alex Bennée,
Peter Crosthwaite
On 05/03/2016 04:36 AM, Sergey Fedorov wrote:
> On 03/05/16 17:34, Sergey Fedorov wrote:
>> > From: Sergey Fedorov <serge.fdrv@gmail.com>
>> >
>> > This comment should have been deleted by commit 0ac087f1f3ae ("removed
>> > unused code") but somehow it is still here. There's no point to keep it.
>> >
>> > Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
>> > Signed-off-by: Sergey Fedorov <serge.fedorov@linaro.org>
> Sorry, should be:
>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
>
> Also, this patch is based on a commit:
> 3c712db2c10b ("cpu-exec: Move TB chaining into tb_find_fast()")
> from:
> git://github.com/rth7680/qemu.git tcg-next
>
> Kind regards,
> Sergey
>
Applied to tcg-next with the fixed s-o-b.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-04 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-03 14:34 [Qemu-devel] [PATCH] cpu-exec: Remove relic orphaned comment Sergey Fedorov
2016-05-03 14:36 ` Sergey Fedorov
2016-05-04 17:56 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).