qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sean Bruno <sbruno@freebsd.org>
To: haris iqbal <haris.phnx@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v1] Changed malloc to g_malloc, free to g_free in bsd-user/qemu.h
Date: Tue, 3 May 2016 10:32:07 -0700	[thread overview]
Message-ID: <5728E097.1060507@freebsd.org> (raw)
In-Reply-To: <CAE_WKMyO1LjEZ_T5-O7=X=MOpSe7AqTeXTOOkfiZ114bGjNeDQ@mail.gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512



On 05/03/16 02:45, haris iqbal wrote:
> Just a reminder. waiting for a review for the previous patch.
> 
> On Tue, Apr 5, 2016 at 6:39 PM, Md Haris Iqbal
> <haris.phnx@gmail.com> wrote:
>> Signed-off-by: Md Haris Iqbal <haris.phnx@gmail.com> --- 
>> bsd-user/qemu.h | 4 ++-- 1 file changed, 2 insertions(+), 2
>> deletions(-)
>> 
>> diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index
>> 03b502a..5fac42e 100644 --- a/bsd-user/qemu.h +++
>> b/bsd-user/qemu.h @@ -357,7 +357,7 @@ static inline void
>> *lock_user(int type, abi_ulong guest_addr, long len, int copy 
>> #ifdef DEBUG_REMAP { void *addr; -        addr = malloc(len); +
>> addr = g_malloc(len); if (copy) memcpy(addr, g2h(guest_addr),
>> len); else @@ -383,7 +383,7 @@ static inline void
>> unlock_user(void *host_ptr, abi_ulong guest_addr, return; if (len
>> > 0) memcpy(g2h(guest_addr), host_ptr, len); -
>> free(host_ptr); +    g_free(host_ptr); #endif }
>> 
>> -- 1.9.1
>> 
> 
> 
> 

If this is the only patch needing review for the bsd-user code, please
put me down as Reviewed by.

Reviewed-by: Sean Bruno <sbruno@freebsd.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAEBCgBmBQJXKOCTXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx
MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kZE0H/06zauEdcv8Y0K3KI3r2ioFS
M6nqr/UXjqazqIeArBKDC+cnv47cnwH/x6Udn2on+CY9kR91QyUeG/DKUJdEp6Hs
idUuTf3L0W8nhNUUXE9bwVI7H2KWpDzHJ52dnHuSXaQZnBE6Q1AFk0ge+hg+XcCU
BsOqEkTAcxchOnvQJgNpMyXofI35QvSXqqaijTozMdGT7iHG0nKpO6KNW11ash2U
YEVNs9nkr9I+B+qKPhhgX+v4dAuHSekaEstWbkqqSa4YsmqIylL1MNTpRTbEUSEG
fScXKCOy3lANGV6u1sTzLIffR6N3WhkaYCuzYsQ7TQL/TAuYpBrQq7TQt8lb0Do=
=qmUg
-----END PGP SIGNATURE-----

  reply	other threads:[~2016-05-03 17:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 13:09 [Qemu-devel] [PATCH v1] Changed malloc to g_malloc, free to g_free in bsd-user/qemu.h Md Haris Iqbal
2016-05-03  9:45 ` haris iqbal
2016-05-03 17:32   ` Sean Bruno [this message]
2016-05-03 18:10     ` haris iqbal
2016-05-03 19:02       ` Peter Maydell
2016-05-03 19:08         ` haris iqbal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5728E097.1060507@freebsd.org \
    --to=sbruno@freebsd.org \
    --cc=armbru@redhat.com \
    --cc=haris.phnx@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).