From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axeBZ-0006x2-3R for qemu-devel@nongnu.org; Tue, 03 May 2016 13:32:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axeBN-00071i-HU for qemu-devel@nongnu.org; Tue, 03 May 2016 13:32:31 -0400 References: <1459861743-4514-1-git-send-email-haris.phnx@gmail.com> From: Sean Bruno Message-ID: <5728E097.1060507@freebsd.org> Date: Tue, 3 May 2016 10:32:07 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] Changed malloc to g_malloc, free to g_free in bsd-user/qemu.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: haris iqbal , QEMU Developers Cc: QEMU Trivial , Paolo Bonzini , Markus Armbruster , Peter Maydell -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 05/03/16 02:45, haris iqbal wrote: > Just a reminder. waiting for a review for the previous patch. > > On Tue, Apr 5, 2016 at 6:39 PM, Md Haris Iqbal > wrote: >> Signed-off-by: Md Haris Iqbal --- >> bsd-user/qemu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 >> deletions(-) >> >> diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index >> 03b502a..5fac42e 100644 --- a/bsd-user/qemu.h +++ >> b/bsd-user/qemu.h @@ -357,7 +357,7 @@ static inline void >> *lock_user(int type, abi_ulong guest_addr, long len, int copy >> #ifdef DEBUG_REMAP { void *addr; - addr = malloc(len); + >> addr = g_malloc(len); if (copy) memcpy(addr, g2h(guest_addr), >> len); else @@ -383,7 +383,7 @@ static inline void >> unlock_user(void *host_ptr, abi_ulong guest_addr, return; if (len >> > 0) memcpy(g2h(guest_addr), host_ptr, len); - >> free(host_ptr); + g_free(host_ptr); #endif } >> >> -- 1.9.1 >> > > > If this is the only patch needing review for the bsd-user code, please put me down as Reviewed by. Reviewed-by: Sean Bruno -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJXKOCTXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kZE0H/06zauEdcv8Y0K3KI3r2ioFS M6nqr/UXjqazqIeArBKDC+cnv47cnwH/x6Udn2on+CY9kR91QyUeG/DKUJdEp6Hs idUuTf3L0W8nhNUUXE9bwVI7H2KWpDzHJ52dnHuSXaQZnBE6Q1AFk0ge+hg+XcCU BsOqEkTAcxchOnvQJgNpMyXofI35QvSXqqaijTozMdGT7iHG0nKpO6KNW11ash2U YEVNs9nkr9I+B+qKPhhgX+v4dAuHSekaEstWbkqqSa4YsmqIylL1MNTpRTbEUSEG fScXKCOy3lANGV6u1sTzLIffR6N3WhkaYCuzYsQ7TQL/TAuYpBrQq7TQt8lb0Do= =qmUg -----END PGP SIGNATURE-----