From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axeqJ-0003hs-TL for qemu-devel@nongnu.org; Tue, 03 May 2016 14:14:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axeq8-0008Rx-5U for qemu-devel@nongnu.org; Tue, 03 May 2016 14:14:38 -0400 Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]:36042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axeq6-0008E8-SO for qemu-devel@nongnu.org; Tue, 03 May 2016 14:14:32 -0400 Received: by mail-pa0-x242.google.com with SMTP id i5so2377184pag.3 for ; Tue, 03 May 2016 11:14:14 -0700 (PDT) References: <1462282457-24574-1-git-send-email-ashijeetacharya@gmail.com> <20160503140114.GA11694@redhat.com> From: Ashi Message-ID: <5728EA66.3040909@gmail.com> Date: Tue, 3 May 2016 23:43:58 +0530 MIME-Version: 1.0 In-Reply-To: <20160503140114.GA11694@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Modify net/socket.c to use functions from include/qemu/sockets.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: jasowang@redhat.com, qemu-devel@nongnu.org On Tuesday 03 May 2016 07:31 PM, Daniel P. Berrange wrote: > On Tue, May 03, 2016 at 07:04:17PM +0530, Ashijeet Acharya wrote: >> From: Ashijeet >> >> Replaced connect()/listen()/parse_host_port() in net/socket.c >> with inet_connect()/inet_listen/inet_parse() in include/qemu/sockets.h. > > If you're going to re-work this, then I think it'd be better to > go straight to using socket_connect() / socket_listen() / socket_parse() > which are QAPI based. The inet_* function should eventually be going > away once everything is using the QAPI based socket_* functions, so > adding more usage of them is not too desirable. > Yeah sure I can do that. Also I was wondering if there is a similar function for bind because the task listed on wiki BiteSized also expects replacement of bind(). So maybe adding/defining socket_bind() in util/qemu-sockets.c and the header include/qemu/sockets.h be helpful. Thanks! Ashijeet > Regards, > Daniel >