From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axs2E-0002EZ-3Q for qemu-devel@nongnu.org; Wed, 04 May 2016 04:20:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axs1y-0002AT-M8 for qemu-devel@nongnu.org; Wed, 04 May 2016 04:19:48 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:46606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axs1x-000267-IB for qemu-devel@nongnu.org; Wed, 04 May 2016 04:19:38 -0400 References: <1460096797-14916-1-git-send-email-zhang.zhanghailiang@huawei.com> <1460096797-14916-33-git-send-email-zhang.zhanghailiang@huawei.com> <571F0F26.808@redhat.com> From: Hailiang Zhang Message-ID: <5729B051.1060703@huawei.com> Date: Wed, 4 May 2016 16:18:25 +0800 MIME-Version: 1.0 In-Reply-To: <571F0F26.808@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH COLO-Frame v16 32/35] net: Add notifier/callback for netdev init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , qemu-devel@nongnu.org Cc: peter.huangpeng@huawei.com, xiecl.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com, quintela@redhat.com, armbru@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com, zhangchen.fnst@cn.fujitsu.com, hongyang.yang@easystack.cn On 2016/4/26 14:48, Jason Wang wrote: > > > On 04/08/2016 02:26 PM, zhanghailiang wrote: >> We can register some callback for this notifier, >> this will be used by COLO to register a callback which >> will add each netdev a buffer filter. >> >> Signed-off-by: zhanghailiang >> Cc: Jason Wang >> Cc: Yang Hongyang >> --- >> v16: >> - Simplify the codes by using some helpers in QEMU >> v14: >> - New patch >> --- >> include/net/net.h | 3 +++ >> net/net.c | 12 ++++++++++++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/include/net/net.h b/include/net/net.h >> index 73e4c46..d8abe7a 100644 >> --- a/include/net/net.h >> +++ b/include/net/net.h >> @@ -8,6 +8,7 @@ >> #include "net/queue.h" >> #include "migration/vmstate.h" >> #include "qapi-types.h" >> +#include "qemu/notify.h" >> >> #define MAX_QUEUE_NUM 1024 >> >> @@ -176,6 +177,8 @@ struct NICInfo { >> int nvectors; >> }; >> >> +void netdev_init_add_notifier(Notifier *notify); >> + >> extern int nb_nics; >> extern NICInfo nd_table[MAX_NICS]; >> extern int default_net; >> diff --git a/net/net.c b/net/net.c >> index 0ad6217..6d846f4 100644 >> --- a/net/net.c >> +++ b/net/net.c >> @@ -56,6 +56,9 @@ >> static VMChangeStateEntry *net_change_state_entry; >> static QTAILQ_HEAD(, NetClientState) net_clients; >> >> +static NotifierList netdev_init_notifiers = >> + NOTIFIER_LIST_INITIALIZER(netdev_init_notifiers); >> + >> const char *host_net_devices[] = { >> "tap", >> "socket", >> @@ -931,6 +934,10 @@ static int net_init_nic(const NetClientOptions *opts, const char *name, >> return idx; >> } >> >> +void netdev_init_add_notifier(Notifier *notify) >> +{ >> + notifier_list_add(&netdev_init_notifiers, notify); >> +} > > Nitpick, like other notifier, we'd better have 'register' in the name of > this function, (e.g something like netdev_register_init_notifier()). > OK, I'll fix it in next version, thanks :) >> >> static int (* const net_client_init_fun[NET_CLIENT_OPTIONS_KIND__MAX])( >> const NetClientOptions *opts, >> @@ -1017,6 +1024,11 @@ static int net_client_init1(const void *object, int is_netdev, Error **errp) >> } >> return -1; >> } >> + if (is_netdev) { >> + const Netdev *netdev = object; >> + >> + notifier_list_notify(&netdev_init_notifiers, netdev->id); >> + } >> return 0; >> } >> > > > . >