From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axx0y-0006Vz-Km for qemu-devel@nongnu.org; Wed, 04 May 2016 09:39:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axx0l-00056a-La for qemu-devel@nongnu.org; Wed, 04 May 2016 09:38:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axx0l-00053y-En for qemu-devel@nongnu.org; Wed, 04 May 2016 09:38:43 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 440365F2C for ; Wed, 4 May 2016 13:38:32 +0000 (UTC) References: <87oa8mf4sj.fsf@emacs.mitica> From: Eric Blake Message-ID: <5729FB57.60904@redhat.com> Date: Wed, 4 May 2016 07:38:31 -0600 MIME-Version: 1.0 In-Reply-To: <87oa8mf4sj.fsf@emacs.mitica> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4dox7TegncSXckTMCh8ocuGtjqlNBhh9E" Subject: Re: [Qemu-devel] Migration ToDo list (a.k.a. Rant) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com, QEMU Developer This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4dox7TegncSXckTMCh8ocuGtjqlNBhh9E Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/04/2016 05:20 AM, Juan Quintela wrote: > - migration capabilities and parameters > this is a mess. Not, is worse than that. I don't know who is to > blame here, but something needs to be done: >=20 > void qmp_migrate_set_parameters(bool has_compress_level, > int64_t compress_level, > bool has_compress_threads, > int64_t compress_threads, > bool has_decompress_threads, > int64_t decompress_threads, > bool has_x_cpu_throttle_initial, > int64_t x_cpu_throttle_initial, > bool has_x_cpu_throttle_increment, > int64_t x_cpu_throttle_increment, > bool has_multifd_threads, > int64_t multifd_threads, > Error **errp) I've got a QAPI patch in the pipeline that makes this MUCH simpler, by boxing everything through a single MigrationParameter* pointer rather than an exploded list of parameters. > migrate_set_capability > Minor nickpit, if it only allow booleans, "migrate_set_capability= x-multifd", > should be an equivalent of "migrate_set_capability x-multifd on" That's HMP - you can make HMP do whatever you want without breaking back-compat. >=20 > migrate_set_cache_size > migrate_set_downtime > migrate_set_speed > This three should be claimed obsolete, deprecated, whatever, and > make it on top of next one Again, HMP can make this change easy, even if it has to call out to different QMP under the hood. >=20 > migrate_set_parameter >=20 > Now to read the migration information: >=20 > migrate_capabilities > good > migrate_parameters > good Why we need two commands is beyond me - one command that lists everything (capabilities AND parameters) should be sufficient. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4dox7TegncSXckTMCh8ocuGtjqlNBhh9E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXKftXAAoJEKeha0olJ0NqJYgH/RGaIwXxFqNc0nNJ+gTUYizq iEBkoZn3W/fb5v+3z6U9UcVnciVUQJgcG/gkyKhhVFxpGu62trUO2+gZqOe6f3hd B855WISLw0qzoITkEyJXeLnOdfdD+5FJofCvOP/9F35DUV5YFivaytBK4Te0XqAq un8HlhpjL0KovZt7m+Qg7Ty/v/jTe9+BPastxoYSamSS2VlviNpzNRwWpR3MQaLW /KIMpj2v5e3cJf5rc6I33BT7ACenz6EB57hbsAgGQGS/Ws9AKT1tjvQVv0IEJxNe cJeFZp05hHMrvyBaMPjlk9L8GmgYOAZGBe7n6oopNYacaZXWRBNgrsTbcaumY2s= =Xz/N -----END PGP SIGNATURE----- --4dox7TegncSXckTMCh8ocuGtjqlNBhh9E--