From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org, Pooja Dhannawat <dhannawatpooja1@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] hw/display/blizzard: Expand out macros
Date: Wed, 4 May 2016 08:30:07 -0600 [thread overview]
Message-ID: <572A076F.3090808@redhat.com> (raw)
In-Reply-To: <1462371352-21498-2-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On 05/04/2016 08:15 AM, Peter Maydell wrote:
> Now that we can assume that only depth 32 is possible, there's no need
> for the COPY_PIXEL1 and PIXEL_TYPE macros, and the SKIP_PIXEL, COPY_PIXEL
> and SWAP_WORDS macros aren't used at all. Expand out COPY_PIXEL1 and
> PIXEL_TYPE where they are used, delete the unused macro definitions, and
> expand out the uses of glue(name_prefix, DEPTH).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/display/blizzard_template.h | 55 +++++++++++++-----------------------------
> 1 file changed, 17 insertions(+), 38 deletions(-)
I might have broken into more patches, one per macro expansion; but the
final patch was still small enough to review when merged, so keep it the
way you have it.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-05-04 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 14:15 [Qemu-devel] [PATCH 0/2] hw/display/blizzard: remove blizzard_template.h Peter Maydell
2016-05-04 14:15 ` [Qemu-devel] [PATCH 1/2] hw/display/blizzard: Expand out macros Peter Maydell
2016-05-04 14:30 ` Eric Blake [this message]
2016-05-04 14:15 ` [Qemu-devel] [PATCH 2/2] hw/display/blizzard: Remove blizzard_template.h Peter Maydell
2016-05-04 14:31 ` Eric Blake
2016-05-09 7:48 ` [Qemu-devel] [PATCH 0/2] hw/display/blizzard: remove blizzard_template.h Gerd Hoffmann
2016-05-09 9:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572A076F.3090808@redhat.com \
--to=eblake@redhat.com \
--cc=dhannawatpooja1@gmail.com \
--cc=kraxel@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).