From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org, Pooja Dhannawat <dhannawatpooja1@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] hw/display/blizzard: Remove blizzard_template.h
Date: Wed, 4 May 2016 08:31:40 -0600 [thread overview]
Message-ID: <572A07CC.4070004@redhat.com> (raw)
In-Reply-To: <1462371352-21498-3-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On 05/04/2016 08:15 AM, Peter Maydell wrote:
> We no longer need to do the "multiply include this header" trick with
> blizzard_template.h, and it is only used in a single .c file, so just
> put its contents inline in blizzard.c.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/display/blizzard.c | 79 +++++++++++++++++++++++++++++++++-
> hw/display/blizzard_template.h | 97 ------------------------------------------
> 2 files changed, 77 insertions(+), 99 deletions(-)
> delete mode 100644 hw/display/blizzard_template.h
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-05-04 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 14:15 [Qemu-devel] [PATCH 0/2] hw/display/blizzard: remove blizzard_template.h Peter Maydell
2016-05-04 14:15 ` [Qemu-devel] [PATCH 1/2] hw/display/blizzard: Expand out macros Peter Maydell
2016-05-04 14:30 ` Eric Blake
2016-05-04 14:15 ` [Qemu-devel] [PATCH 2/2] hw/display/blizzard: Remove blizzard_template.h Peter Maydell
2016-05-04 14:31 ` Eric Blake [this message]
2016-05-09 7:48 ` [Qemu-devel] [PATCH 0/2] hw/display/blizzard: remove blizzard_template.h Gerd Hoffmann
2016-05-09 9:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572A07CC.4070004@redhat.com \
--to=eblake@redhat.com \
--cc=dhannawatpooja1@gmail.com \
--cc=kraxel@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).