From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34393)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chengang@emindsoft.com.cn>) id 1ayLTM-0002ns-4v
	for qemu-devel@nongnu.org; Thu, 05 May 2016 11:45:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chengang@emindsoft.com.cn>) id 1ayLTA-0003KX-B4
	for qemu-devel@nongnu.org; Thu, 05 May 2016 11:45:46 -0400
Received: from out4433.biz.mail.alibaba.com ([47.88.44.33]:61965)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chengang@emindsoft.com.cn>) id 1ayLTA-00035X-0x
	for qemu-devel@nongnu.org; Thu, 05 May 2016 11:45:40 -0400
Message-ID: <572B5D59.6000006@emindsoft.com.cn>
Date: Thu, 05 May 2016 22:48:57 +0800
From: Chen Gang <chengang@emindsoft.com.cn>
MIME-Version: 1.0
References: <1459260825-5710-1-git-send-email-chengang@emindsoft.com.cn>
	<CAFEAcA9u=Nfau+-wRDUu4HWCfzyf_0qiAVcteajg5gvz--2vZw@mail.gmail.com>
In-Reply-To: <CAFEAcA9u=Nfau+-wRDUu4HWCfzyf_0qiAVcteajg5gvz--2vZw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use target address
 instead of host address for microblaze restorer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>, Chris Metcalf <cmetcalf@ezchip.com>, Laurent Vivier <laurent@vivier.eu>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "walt@tilera.com" <walt@tilera.com>, Riku Voipio <riku.voipio@iki.fi>, QEMU Developers <qemu-devel@nongnu.org>, Chen Gang <gang.chen.5i5j@gmail.com>

On 5/5/16 00:05, Peter Maydell wrote:
> On 29 March 2016 at 15:13,  <chengang@emindsoft.com.cn> wrote:
>> From: Chen Gang <chengang@emindsoft.com.cn>
>>
>> The return address is in target space, so the restorer address needs to
>> be target space, too.
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  linux-user/signal.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/linux-user/signal.c b/linux-user/signal.c
>> index 4157154..c0a6f7e 100644
>> --- a/linux-user/signal.c
>> +++ b/linux-user/signal.c
>> @@ -3532,7 +3532,8 @@ static void setup_frame(int sig, struct target_sigaction *ka,
>>
>>          /* Return from sighandler will jump to the tramp.
>>             Negative 8 offset because return is rtsd r15, 8 */
>> -        env->regs[15] = ((unsigned long)frame->tramp) - 8;
>> +        env->regs[15] = frame_addr + offsetof(struct target_signal_frame, tramp)
>> +                                   - 8;
>>      }
>>
>>      /* Set up registers for signal handler */
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 

Thank all of you for the 2 patches reviewing.

I guess, this month, I may have free time (at least, will not be as busy
as the previous month), I shall finish tilegx floating point insns (it
has been delayed too long).


Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.