From: Michael Tokarev <mjt@tls.msk.ru>
To: Markus Armbruster <armbru@redhat.com>, Peter Xu <peterx@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com,
qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries
Date: Fri, 6 May 2016 21:39:37 +0300 [thread overview]
Message-ID: <572CE4E9.1030108@msgid.tls.msk.ru> (raw)
In-Reply-To: <87vb4eo72f.fsf@blackfin.pond.sub.org>
22.03.2016 18:39, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
>
>> Here we use one g_strdup_printf() to replace the two stack allocated
>> array, considering it's more convenient, safe, and as long as it's
>> called rarely only when quorum device opens. This will remove the
>> unbound stack warning when compiling with "-Wstack-usage=1000000".
>>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: Peter Xu <peterx@redhat.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> I lack the time to take this through my tree before my Easter vacation.
> Nominating for qemu-trivial, assuming Luiz doesn't mind.
(Finally) applied to -trivial, thanks!
/mjt
prev parent reply other threads:[~2016-05-06 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 2:37 [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries Peter Xu
2016-03-22 15:39 ` Markus Armbruster
2016-05-06 18:39 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572CE4E9.1030108@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).