From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
peter.maydell@linaro.org, stefanha@gmail.com
Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com,
jfrei@linux.vnet.ibm.com, alex.bennee@linaro.org,
Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions
Date: Fri, 4 Nov 2016 10:06:19 +0100 [thread overview]
Message-ID: <572b71d8-eaef-d06c-be86-e8c5287f2568@redhat.com> (raw)
In-Reply-To: <20161102162103.66480-1-cornelia.huck@de.ibm.com>
On 02/11/2016 17:21, Cornelia Huck wrote:
> Commit 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type")
> attempted to convert all users of run_on_cpu to use the new
> run_on_cpu_data type. It missed to change the called sigp_* routines,
> however. Fix that.
>
> Fixes: 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type")
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> Peter, Stefan: This fixes building for s390x which is currently
> broken (at least with kvm enabled). Two questions:
> - Will you pick this up as a build fix, or should I do a pull req?
> - Can we do anything more to catch errors like this?
Fam, can we use the linux-user support in tests/docker to build QEMU
with KVM support on ARM/MIPS/s390? It would be already much better,
even if it obviously cannot run with KVM.
Paolo
next prev parent reply other threads:[~2016-11-04 9:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 16:21 [Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions Cornelia Huck
2016-11-04 8:23 ` Christian Borntraeger
2016-11-04 8:25 ` Christian Borntraeger
2016-11-04 9:06 ` Paolo Bonzini [this message]
2016-11-07 7:36 ` Fam Zheng
2016-11-07 8:34 ` Paolo Bonzini
2016-11-07 9:00 ` Fam Zheng
2016-11-07 11:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572b71d8-eaef-d06c-be86-e8c5287f2568@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=famz@redhat.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).