From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2aSC-0002Xx-QI for qemu-devel@nongnu.org; Fri, 04 Nov 2016 05:06:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2aS7-0004Ww-PQ for qemu-devel@nongnu.org; Fri, 04 Nov 2016 05:06:28 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:35847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2aS7-0004W7-I7 for qemu-devel@nongnu.org; Fri, 04 Nov 2016 05:06:23 -0400 Received: by mail-wm0-x243.google.com with SMTP id c17so2844206wmc.3 for ; Fri, 04 Nov 2016 02:06:23 -0700 (PDT) Sender: Paolo Bonzini References: <20161102162103.66480-1-cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: <572b71d8-eaef-d06c-be86-e8c5287f2568@redhat.com> Date: Fri, 4 Nov 2016 10:06:19 +0100 MIME-Version: 1.0 In-Reply-To: <20161102162103.66480-1-cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , peter.maydell@linaro.org, stefanha@gmail.com Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, alex.bennee@linaro.org, Fam Zheng On 02/11/2016 17:21, Cornelia Huck wrote: > Commit 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type") > attempted to convert all users of run_on_cpu to use the new > run_on_cpu_data type. It missed to change the called sigp_* routines, > however. Fix that. > > Fixes: 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type") > Signed-off-by: Cornelia Huck > --- > Peter, Stefan: This fixes building for s390x which is currently > broken (at least with kvm enabled). Two questions: > - Will you pick this up as a build fix, or should I do a pull req? > - Can we do anything more to catch errors like this? Fam, can we use the linux-user support in tests/docker to build QEMU with KVM support on ARM/MIPS/s390? It would be already much better, even if it obviously cannot run with KVM. Paolo