public inbox for qemu-devel@nongnu.org
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org,
	Richard Henderson <richard.henderson@linaro.org>,
	Mahmoud Mandour <ma.mandourr@gmail.com>,
	Alexandre Iooss <erdnaxe@crans.org>
Subject: Re: [PATCH 3/3] tests/tcg/plugins/mem.c: fix endian swap in update_region_info
Date: Wed, 25 Mar 2026 08:25:11 -0700	[thread overview]
Message-ID: <572d24c1-a930-4164-b331-c6d408b3e2ce@linaro.org> (raw)
In-Reply-To: <87qzp82awo.fsf@draig.linaro.org>

On 3/25/26 8:20 AM, Alex Bennée wrote:
> Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> 
>> value returned by qemu_plugin_mem_get_value() is always in host-endian
>> order, so we need to convert TO target endianness and not FROM it.
>>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> 
>> ---
>>   tests/tcg/plugins/mem.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>

As a complement, GUINT*_FROM_* and GUINT*_TO_* do the same thing (they 
both swap value). The FROM/TO name simply acts as a documentation when 
reading the code. That's why it was working before as expected, even 
though it was sending the wrong hint for the reader.

Regards,
Pierrick


  reply	other threads:[~2026-03-25 15:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25  2:42 [PATCH 0/3] plugins: fix endianness for qemu_plugin_mem_get_value() Pierrick Bouvier
2026-03-25  2:42 ` [PATCH 1/3] tcg: Pass host-endian values to plugin_gen_mem_callbacks_* Pierrick Bouvier
2026-03-25  2:42 ` [PATCH 2/3] include/plugins/qemu-plugin.h: add note about endianness of value returned by qemu_plugin_mem_get_value Pierrick Bouvier
2026-03-25 15:17   ` Alex Bennée
2026-03-25 15:23     ` Pierrick Bouvier
2026-03-25  2:42 ` [PATCH 3/3] tests/tcg/plugins/mem.c: fix endian swap in update_region_info Pierrick Bouvier
2026-03-25 15:20   ` Alex Bennée
2026-03-25 15:25     ` Pierrick Bouvier [this message]
2026-03-25 21:53 ` [PATCH 0/3] plugins: fix endianness for qemu_plugin_mem_get_value() Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572d24c1-a930-4164-b331-c6d408b3e2ce@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=erdnaxe@crans.org \
    --cc=ma.mandourr@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox