From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Baumann <Andrew.Baumann@microsoft.com>,
Sylvain Garrigues <sylvain@sylvaingarrigues.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer
Date: Mon, 9 May 2016 12:27:50 +0200 [thread overview]
Message-ID: <57306626.6050702@redhat.com> (raw)
In-Reply-To: <BLUPR0301MB203485DA67E205999C1F0AC49E6F0@BLUPR0301MB2034.namprd03.prod.outlook.com>
On 22/04/2016 13:30, Andrew Baumann wrote:
>> From: Sylvain Garrigues [mailto:sylvain@sylvaingarrigues.com]
>> Sent: Friday, 22 April 2016 13:27
>>
>> Le 22 avr. 2016 à 13:22, Andrew Baumann
>> <Andrew.Baumann@microsoft.com> a écrit :
>>>> + stl_le_phys(&s->dma_as, value + 16, tmp_xres * tmp_yres
>>>> + * (tmp_bpp >> 3));
>>>
>>> Personal style nit: I prefer * 8 rather than >> 3, because it's more immediately
>> obvious what you're computing, a trivial optimisation for the compiler
Note that it's only trivial for unsigned dividend. A signed dividend
has >> rounding towards -infinity and / rounding towards zero.
Paolo
next prev parent reply other threads:[~2016-05-09 10:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 10:41 [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer Sylvain Garrigues
2016-04-21 12:45 ` Peter Maydell
2016-04-21 12:50 ` Sylvain Garrigues
2016-04-21 12:54 ` Peter Maydell
2016-04-21 13:15 ` Sylvain Garrigues
2016-04-21 13:42 ` Peter Maydell
2016-04-21 14:07 ` Sylvain Garrigues
2016-04-21 16:06 ` [Qemu-devel] [Qemu-arm] " Stephen Warren
2016-04-22 7:17 ` Peter Crosthwaite
2016-04-22 7:46 ` Gerd Hoffmann
2016-04-22 11:56 ` Andrew Baumann
2016-04-22 15:43 ` Stephen Warren
2016-04-22 16:50 ` Peter Crosthwaite
2016-04-22 11:44 ` Andrew Baumann
2016-04-22 16:55 ` Peter Crosthwaite
2016-04-22 18:09 ` Sylvain Garrigues
2016-04-22 11:22 ` [Qemu-devel] " Andrew Baumann
2016-04-22 11:26 ` Sylvain Garrigues
2016-04-22 11:30 ` Andrew Baumann
2016-04-22 12:12 ` Sylvain Garrigues
2016-05-09 10:27 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-22 11:42 Sylvain Garrigues
2016-05-02 21:21 ` Sylvain Garrigues
2016-05-03 0:03 ` Peter Maydell
2016-05-04 15:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57306626.6050702@redhat.com \
--to=pbonzini@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sylvain@sylvaingarrigues.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).