From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azjZX-0003uE-JT for qemu-devel@nongnu.org; Mon, 09 May 2016 07:42:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azjZS-000771-B3 for qemu-devel@nongnu.org; Mon, 09 May 2016 07:41:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azjZS-00076x-5E for qemu-devel@nongnu.org; Mon, 09 May 2016 07:41:54 -0400 References: <1461123261-15408-1-git-send-email-arei.gonglei@huawei.com> From: Paolo Bonzini Message-ID: <5730777D.4070606@redhat.com> Date: Mon, 9 May 2016 13:41:49 +0200 MIME-Version: 1.0 In-Reply-To: <1461123261-15408-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] memory: some little optimzation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei , qemu-devel@nongnu.org Cc: famz@redhat.com, peter.huangpeng@huawei.com On 20/04/2016 05:34, Gonglei wrote: > Please see the details in each patch. >=20 > Gonglei (3): > memory: drop find_ram_block() > exec: adjuest rcu_read_lock requiement > memory: pass RAMBlock as a agrument Hi, patches 1 and 2 look good. Please send v2 according to Fam remarks. For patch 3, I think it's okay if memory.c touches block->fd directly. Then the functions can be just removed. I have a patch pending for 2.7 that I'll send in the next weeks. Thanks, Paolo