From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azmTR-00037V-Sg for qemu-devel@nongnu.org; Mon, 09 May 2016 10:47:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azmTQ-00055D-PB for qemu-devel@nongnu.org; Mon, 09 May 2016 10:47:53 -0400 References: <1462788216-14009-1-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5730A309.9010004@redhat.com> Date: Mon, 9 May 2016 08:47:37 -0600 MIME-Version: 1.0 In-Reply-To: <1462788216-14009-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R7UqoojruE5aVCVu8OOeiW061V4SUrLHp" Subject: Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak in 'aio_write -z' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --R7UqoojruE5aVCVu8OOeiW061V4SUrLHp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/09/2016 04:03 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > qemu-io-cmds.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake Perhaps it would be easier to convert all the mid-function returns into 'goto cleanup', so that we don't have to repeat the cleanups everywhere, but that's more invasive. >=20 > diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c > index e34f777..41580b5 100644 > --- a/qemu-io-cmds.c > +++ b/qemu-io-cmds.c > @@ -1699,6 +1699,7 @@ static int aio_write_f(BlockBackend *blk, int arg= c, char **argv) > int64_t count =3D cvtnum(argv[optind]); > if (count < 0) { > print_cvtnum_err(count, argv[optind]); > + g_free(ctx); > return 0; > } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --R7UqoojruE5aVCVu8OOeiW061V4SUrLHp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXMKMKAAoJEKeha0olJ0Nq+Y4IAIKCmFrhEZ/W1B4khE3jDizY difKLfrq/1XYq73gjippyu5uPXxWguyQL24810NlV3JyxGzp9MBXIZi5B3o1xU9T qNxQpDuN7diCuA0WbGJwBXJRh1cO4AA8JGlRAnBhN0HDK4aJiqUU2awZpNcc0yOI +2jDpmEgirs1An/5kAogYQ+xYI6l9P29/liE8IHwIKZL6JjZVpAtYAM4w92FIPWM Q7zw+kJLUD6dcP7uhUYZoEHsnsEKMCm/GFvqC41pmtw9XBgsh9lYCWgRSiwPeOA4 3/ErzvH518990WtW0rEgUABWI0Si/9zlJWyGo2L/TadVq8DMXtmXAKpZAb7RA7o= =wdiT -----END PGP SIGNATURE----- --R7UqoojruE5aVCVu8OOeiW061V4SUrLHp--