From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azmyr-0001po-NR for qemu-devel@nongnu.org; Mon, 09 May 2016 11:20:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azmyn-0004X4-Eg for qemu-devel@nongnu.org; Mon, 09 May 2016 11:20:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azmyn-0004WP-1K for qemu-devel@nongnu.org; Mon, 09 May 2016 11:20:17 -0400 References: <1462558292-2126-1-git-send-email-ehabkost@redhat.com> <1462558292-2126-8-git-send-email-ehabkost@redhat.com> From: Eric Blake Message-ID: <5730AAAF.7040205@redhat.com> Date: Mon, 9 May 2016 09:20:15 -0600 MIME-Version: 1.0 In-Reply-To: <1462558292-2126-8-git-send-email-ehabkost@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jbmvJe9v5CEhlu3RTJOKior2UFjexfUP3" Subject: Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Christian Borntraeger , libvir-list@redhat.com, David Hildenbrand , Cornelia Huck , Igor Mammedov , Jiri Denemark , =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jbmvJe9v5CEhlu3RTJOKior2UFjexfUP3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU > properties that are preventing the CPU model from running in the > current host. >=20 > Cc: David Hildenbrand > Cc: Michael Mueller > Cc: Christian Borntraeger > Cc: Cornelia Huck > Cc: Jiri Denemark > Cc: libvir-list@redhat.com > Signed-off-by: Eduardo Habkost > --- > qapi-schema.json | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 54634c4..450e6e7 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2948,11 +2948,19 @@ > # Virtual CPU definition. > # > # @name: the name of the CPU definition > +# @runnable: true if the CPU model is runnable using the current > +# machine and accelerator. Optional. Since 2.6. You've missed 2.6. Also, the typical spelling for a per-member designation is '(since 2.7)', not 'Since 2.7' Why is it optional? Would it hurt to always be present in qemu new enough to understand why it is needed? > +# @unavailable-features: List of properties that prevent the CPU > +# model from running in the current host, > +# if @runnable is false. Optional. > +# Since 2.6. > # > # Since: 1.2.0 > ## > { 'struct': 'CpuDefinitionInfo', > - 'data': { 'name': 'str' } } > + 'data': { 'name': 'str', > + '*runnable': 'bool', > + '*unavailable-features': [ 'str' ] } } > =20 > ## > # @query-cpu-definitions: >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jbmvJe9v5CEhlu3RTJOKior2UFjexfUP3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXMKqvAAoJEKeha0olJ0Nq4A8IAKJtfeA17/qTMreAOfPWeZw4 fcvy94wCs3xK1V2jo4DphpYvflQtAwYtOiVdMu9OvBF280WLSBPil/a6MaMmoedC uzOghyVvjoJfc3WtHypah2nIRrQ2lQCW8Qn7KKIvkWaKfci/bxkZqRd/YWBqaApz RpGppNP0aGKo1kZ4DhSlVuzY/nGpnheB8DkWkjNs8T18yro/c2SFEyfJK63kV2Zr 1aBepnEQ3GI0S6e4n99UEGdorWajm5D6TjQGEM+glUvFOEDeEde5TF1CVaJceVxr rryFE2IkyAMqbI+7BXMqPeaE4wGpgqun7TKQAN6jsm3M8CN1WBEGhqqU88qlUWY= =anLw -----END PGP SIGNATURE----- --jbmvJe9v5CEhlu3RTJOKior2UFjexfUP3--