From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aznU3-0007aY-T1 for qemu-devel@nongnu.org; Mon, 09 May 2016 11:52:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aznTy-0003Cv-CR for qemu-devel@nongnu.org; Mon, 09 May 2016 11:52:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aznTy-0003Co-3y for qemu-devel@nongnu.org; Mon, 09 May 2016 11:52:30 -0400 References: <1462663968-26607-1-git-send-email-nli@suse.com> <1462663968-26607-2-git-send-email-nli@suse.com> From: Eric Blake Message-ID: <5730B23C.1020009@redhat.com> Date: Mon, 9 May 2016 09:52:28 -0600 MIME-Version: 1.0 In-Reply-To: <1462663968-26607-2-git-send-email-nli@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kfaWEfxh1SxkRS45pIdniBScUVKXqL3GV" Subject: Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nan Li , qemu-devel@nongnu.org Cc: ptesarik@suse.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kfaWEfxh1SxkRS45pIdniBScUVKXqL3GV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/07/2016 05:32 PM, Nan Li wrote: > When running the command "dump-guest-memory", we usually need a large s= pace > of storage to save the dumpfile into disk. It costs not only much time = to > save a file in some of hard disks, but also costs limited storage in ho= st. > In order to reduce the saving time and make it convenient for users to = dump > the guest memory, we introduce a Filesystem in Userspace (FUSE) to save= the > dump file in RAM. It is selectable in the configure file, adding a comp= iling > of package "fuse-devel". It doesn't change the way of dumping guest mem= ory. Why introduce FUSE? Can we reuse NBD instead? >=20 > qemu_fuse_main(int argc, char *argv[]) is the API for qemu code to moun= t > this filesystem. And it only supports these operations just for dumping= > guest memory. >=20 > static struct fuse_operations qemu_fuse_oper =3D { > .getattr =3D qemu_fuse_getattr, > .fgetattr =3D qemu_fuse_fgetattr, > .readdir =3D qemu_fuse_readdir, > .create =3D qemu_fuse_create, > .open =3D qemu_fuse_open, > .read =3D qemu_fuse_read, > .write =3D qemu_fuse_write, > .unlink =3D qemu_fuse_unlink, > }; >=20 > Signed-off-by: Nan Li > --- > Makefile.target | 1 + > configure | 34 +++++ > fuse-mem.c | 376 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > fuse-mem.h | 2 + > 4 files changed, 413 insertions(+) > create mode 100644 fuse-mem.c > create mode 100644 fuse-mem.h New files should be listed in MAINTAINERS; also, new files usually belong better in an appropriate subdirectory rather than littering the top directory (we're trying to reduce, not increase, the number of top-level files). I haven't closely reviewed the patch, because I think the meta-questions about the feature in general should be discussed first. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kfaWEfxh1SxkRS45pIdniBScUVKXqL3GV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXMLI8AAoJEKeha0olJ0NqN38IAJgDop1nSO4lr5lelfgs8HW2 5n63AQ198yZQrwv9mzp9XyXTSXzUeTsDwe0MjMqdrMEkypASgMknAiYegVFFSEIl hp61bI4cTELGNhlp4LtWceze+V+Lb/Lzb2u5KFPOBXWX83g+rfnQU+SXw4n6D2/R BQD12WqSL0E4JlbsJcNQQsQ0PucXXqS04GvEL9a4ioKiX6ucODcx9WhAE+e0xzzD 4FbEt/9b00n1Lmv+62g2bOEin0ys0fnVH0A28axtSZBUfwE6oacr+zc99pYf68pL jbwfYFQlPflJfY5jlnsGy+f8z3IGsrc487tRie9hc4eUx9ckV3xyfYIavR7gTuk= =tAVy -----END PGP SIGNATURE----- --kfaWEfxh1SxkRS45pIdniBScUVKXqL3GV--