From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azoM5-0001vy-6L for qemu-devel@nongnu.org; Mon, 09 May 2016 12:48:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azoM3-0006wC-2A for qemu-devel@nongnu.org; Mon, 09 May 2016 12:48:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azoM2-0006w1-S6 for qemu-devel@nongnu.org; Mon, 09 May 2016 12:48:22 -0400 References: <1462663968-26607-1-git-send-email-nli@suse.com> <1462663968-26607-3-git-send-email-nli@suse.com> From: Eric Blake Message-ID: <5730BF55.8010200@redhat.com> Date: Mon, 9 May 2016 10:48:21 -0600 MIME-Version: 1.0 In-Reply-To: <1462663968-26607-3-git-send-email-nli@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GDofALCs4skRNhNwK3skUabrHRCPlDL1w" Subject: Re: [Qemu-devel] [PATCH 2/2] Dump: add command "fuse-mount" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nan Li , qemu-devel@nongnu.org Cc: ptesarik@suse.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GDofALCs4skRNhNwK3skUabrHRCPlDL1w Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/07/2016 05:32 PM, Nan Li wrote: > Add a "fuse-mount" command to support the Filesystem in Userspace (FUSE= ). > It can mount or unmount the filesystem with both hmp and qmp commands. > It calls the API function qemu_fuse_main(int argc, char *argv[]). >=20 > Signed-off-by: Nan Li > --- > +++ b/qapi-schema.json > @@ -2283,6 +2283,21 @@ > 'returns': 'DumpGuestMemoryCapability' } > =20 > ## > +# @fuse-mount: > +# > +# mount(unmount) fuse system on 'mountpoint'. > +# > +# @is_mount: optional if true, umount the fuse system from the mount p= oint s/umount/unmount/ New QMP commands should favor the use of '-' rather than '_' (as in 'is-mount'). But the name 'is_mount' does not even appear below, so you aren't documenting reality. > +# > +# @mountpoint: the mount point (a path) of fuse system > +# > +# Returns: Nothing on success > +# > +# Since: 2.6 You've missed 2.6. This has to be 2.7 or later. > +## > +{ 'command': 'fuse-mount', 'data': {'unmount': 'bool', 'mountpoint': '= str'} } > + --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GDofALCs4skRNhNwK3skUabrHRCPlDL1w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXML9VAAoJEKeha0olJ0NqyoIH/AqBOyaCA/FqaS2eSKfCNvCY mmimWwTL11xLW/7u1S5eiLZbQYttmQmRGfHfSKTST4xdeofXZmp2Ztbp1ta0Palv AGh8CPvHk2Mzt0uAKNa3IG8qWEctpcykJaxmHN2sUlQFBgkcunt6cq+zVIzUA7gF eqLB+44sqn9rXsBf0aCF0dxACY0yVp3gWNAbq2kftU6ERCWNChChFDXR5ZridaM1 PLamrNvJ8uAOmGBgHI9IU12IUJKgJnXiSbeUkNlh2mhHqXgB1V5PsIi+Mu7+971Q NHnUJXiUjt3uOlggKiAt8LyUS5RXizGFGVENQmR1HzaHoveVamsAZBobQ3x8TXs= =bmsy -----END PGP SIGNATURE----- --GDofALCs4skRNhNwK3skUabrHRCPlDL1w--