From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azzC5-0000CO-Hb for qemu-devel@nongnu.org; Tue, 10 May 2016 00:22:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azzC1-0007EW-6k for qemu-devel@nongnu.org; Tue, 10 May 2016 00:22:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azzC0-0007EP-Tf for qemu-devel@nongnu.org; Tue, 10 May 2016 00:22:45 -0400 References: <1461903820-3092-1-git-send-email-eblake@redhat.com> <1461903820-3092-8-git-send-email-eblake@redhat.com> <87lh3som6o.fsf@dusky.pond.sub.org> <57276E26.5020006@redhat.com> <87r3dja6ue.fsf@dusky.pond.sub.org> <87wpn9esj5.fsf@dusky.pond.sub.org> <572C1AB8.1060705@redhat.com> <87k2j74bbc.fsf@dusky.pond.sub.org> <572CA569.1000702@redhat.com> From: Eric Blake Message-ID: <57316213.6010206@redhat.com> Date: Mon, 9 May 2016 22:22:43 -0600 MIME-Version: 1.0 In-Reply-To: <572CA569.1000702@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="11VMqJhwDk7jEK31DRkpd4fxcFKKup8pN" Subject: Re: [Qemu-devel] [PATCH v3 07/18] qapi: Add json output visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: famz@redhat.com, qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --11VMqJhwDk7jEK31DRkpd4fxcFKKup8pN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/06/2016 08:08 AM, Eric Blake wrote: > On 05/06/2016 06:31 AM, Markus Armbruster wrote: >>> So all that's left are the two output functions. Can we get rid >>> of those, and make Visitor* the only public interface, rather than >>> making every caller have to do upcasts? >> >> The two output functions are >> >> QObject *qmp_output_get_qobject(QmpOutputVisitor *v); >> char *string_output_get_string(StringOutputVisitor *v); >> >>> It looks like outside of the testsuite, all uses of these visitors ar= e >>> local to a single function; and improving the testsuite is not the en= d >>> of the world. Particularly if only the testsuite is using reset, it = may >>> be easier to just patch the testsuite to use a new visitor in the pla= ces >>> where it currently does a reset. >> >> I'm okay with replacing reset by destroy + new in the test suite. >=20 > That part's (relatively) easy, so it will be in the next spin. In fact, it's easier to replace that part in the existing qapi-next branch than it is to revert the addition of qmp_output_visitor_reset(); see patch posted in the other thread (v16A 17/24). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --11VMqJhwDk7jEK31DRkpd4fxcFKKup8pN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXMWITAAoJEKeha0olJ0NqatQIAK1pjTJnhLc/VsNRWmrJHvEv JQVv9EwxhuDXjl/x9dj7Ki4Saa5QPZ98GezNGDopNYpqo8ToUf3kQdn6m94Vy7qQ VykQI4/Cr/tpIL4g28CsXhmnAITvQkaRVc0Vdd4WKKs9UMSMzUcX6cmivzxqG9/t etAZgTAvnIWYZnSMgQlQe1G2SjB7FNmg0bwoD0IZpmhmsc9NUU+zPaHFVaHSh00z G7GZp9JaP3Hb9IywRZSDpEt3rsqiPLPi6TAl1nbTOCg+V1yB5vtQzS/BE7YrchdY 7wVJbE/yhURG/dg9ZmgVxyZLWZkUG3whmu+u48/NePJfsJ48TMLKjtX2EMrnNBg= =BmCA -----END PGP SIGNATURE----- --11VMqJhwDk7jEK31DRkpd4fxcFKKup8pN--