From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52570)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@swsoft.com>) id 1b04qz-0007dk-2D
	for qemu-devel@nongnu.org; Tue, 10 May 2016 06:25:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den-lists@swsoft.com>) id 1b04qu-0006Oa-QE
	for qemu-devel@nongnu.org; Tue, 10 May 2016 06:25:23 -0400
Received: from mx1.parallels.com ([199.115.104.18]:39418)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@swsoft.com>) id 1b04qu-0006O0-IA
	for qemu-devel@nongnu.org; Tue, 10 May 2016 06:25:20 -0400
References: <1462874348-32396-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
From: "Denis V. Lunev" <den-lists@virtuozzo.com>
Message-ID: <5731B709.20102@virtuozzo.com>
Date: Tue, 10 May 2016 13:25:13 +0300
MIME-Version: 1.0
In-Reply-To: <1462874348-32396-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] rfifolock: no need to get thread
 identifier when nesting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

On 05/10/2016 12:59 PM, Changlong Xie wrote:
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
>   util/rfifolock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/rfifolock.c b/util/rfifolock.c
> index c22f5fe..084c2f0 100644
> --- a/util/rfifolock.c
> +++ b/util/rfifolock.c
> @@ -58,9 +58,9 @@ void rfifolock_lock(RFifoLock *r)
>               }
>               qemu_cond_wait(&r->cond, &r->lock);
>           }
> +        qemu_thread_get_self(&r->owner_thread);
>       }
>   
> -    qemu_thread_get_self(&r->owner_thread);
>       r->nesting++;
>       qemu_mutex_unlock(&r->lock);
>   }
Reviewed-by: Denis V. Lunev <den@openvz.org>