From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b053Y-0006pq-T6 for qemu-devel@nongnu.org; Tue, 10 May 2016 06:38:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b053T-0000wm-Rj for qemu-devel@nongnu.org; Tue, 10 May 2016 06:38:24 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b053T-0000wi-LF for qemu-devel@nongnu.org; Tue, 10 May 2016 06:38:19 -0400 Received: by mail-wm0-x244.google.com with SMTP id n129so1954060wmn.1 for ; Tue, 10 May 2016 03:38:19 -0700 (PDT) Sender: Paolo Bonzini References: <1460384056-29494-1-git-send-email-stefanha@redhat.com> <5730BF4C.2080800@redhat.com> <20160510093333.GC11408@stefanha-x1.localdomain> From: Paolo Bonzini Message-ID: <5731BA19.40503@redhat.com> Date: Tue, 10 May 2016 12:38:17 +0200 MIME-Version: 1.0 In-Reply-To: <20160510093333.GC11408@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC for-2.7] block: keep AioContext pointer in BlockBackend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, Kevin Wolf , Max Reitz On 10/05/2016 11:33, Stefan Hajnoczi wrote: >> > >> > I'm not sure I agree with #2, as we should move away for the >> > super-coarse AioContext lock (it is heavyweight and it doesn't play well >> > with multiqueue). Atomics can be used for statistics, while the >> > time-based accounting probably should be made optional because it's >> > heavy-weight and hard to scale. >> > >> > But I do agree with #1, so the idea seems good. > I agree that lightweight options are nicer. Should I resend without #2 > in the commit description? Well, it _is_ a valid concern until someone does the work. :) Paolo