From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmiNu-0003UH-FO for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:20:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmiNs-0003l5-DD for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:20:25 -0400 References: <1474462571-10596-1-git-send-email-kwolf@redhat.com> <1474462571-10596-13-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5731a3f2-4d74-ac2d-4442-001d0ffe9daa@redhat.com> Date: Wed, 21 Sep 2016 09:20:16 -0500 MIME-Version: 1.0 In-Reply-To: <1474462571-10596-13-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="okjFUviw666CiQpPqliL9DOrftfc2WWpT" Subject: Re: [Qemu-devel] [PATCH v3 12/12] block: Remove BB interface from blockdev-add/del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --okjFUviw666CiQpPqliL9DOrftfc2WWpT From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org Message-ID: <5731a3f2-4d74-ac2d-4442-001d0ffe9daa@redhat.com> Subject: Re: [PATCH v3 12/12] block: Remove BB interface from blockdev-add/del References: <1474462571-10596-1-git-send-email-kwolf@redhat.com> <1474462571-10596-13-git-send-email-kwolf@redhat.com> In-Reply-To: <1474462571-10596-13-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/21/2016 07:56 AM, Kevin Wolf wrote: > With this patch, blockdev-add always works on a node level, i.e. it > creates a BDS, but no BB. Consequently, x-blockdev-del doesn't need the= > 'device' option any more, but 'node-name' becomes mandatory. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 124 ++++++++++++++----------------------------= -------- > docs/qmp-commands.txt | 24 +++------- > qapi/block-core.json | 30 +++--------- > 3 files changed, 47 insertions(+), 131 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --okjFUviw666CiQpPqliL9DOrftfc2WWpT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX4pcgAAoJEKeha0olJ0NqmNsH/jd46FG5XTJQMRmxTrVboagj jrwgs2ekh/E/TQCBUAbZDsBZ61PESId+PU3vqESlbwGwNOHUZf9fiByoyOxY13Rx bWeahuPcG38J7uRxkG69OgtDTBv1qfWqkQIzXqiuoUT2WttO05khEE3fcXlYvdqP RWdRBEPMRojFBuB5ppXBOHtEVdjsO0e2M45SO8bufTO8xvUBL4q0s5FxZNJq11Qr zgGR65jAPY/SXo6YYs7z9yBn9GwFooOweGk2UvSd6MgnEpv2bDdf1f568Y+AjSf3 vpdVgE3FQfpLuDluE85fn+pc5o15ntcWogy9MVdmbNd1OdTFB19qHLrJgqfWuwc= =Ttxy -----END PGP SIGNATURE----- --okjFUviw666CiQpPqliL9DOrftfc2WWpT--