From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0RYf-0005ZJ-QG for qemu-devel@nongnu.org; Wed, 11 May 2016 06:40:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0RYc-0004a6-HL for qemu-devel@nongnu.org; Wed, 11 May 2016 06:40:01 -0400 Received: from mail-am1on0145.outbound.protection.outlook.com ([157.56.112.145]:38479 helo=emea01-am1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0RYb-0004ZF-B6 for qemu-devel@nongnu.org; Wed, 11 May 2016 06:39:58 -0400 References: <1462960324-4655-1-git-send-email-den@openvz.org> From: "Denis V. Lunev" Message-ID: <57330BF4.6040404@openvz.org> Date: Wed, 11 May 2016 13:39:48 +0300 MIME-Version: 1.0 In-Reply-To: <1462960324-4655-1-git-send-email-den@openvz.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC for 2.7 0/2] virtio: show guest features in 'info qtree' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Eric Blake On 05/11/2016 12:52 PM, Denis V. Lunev wrote: > It is very convinient and useful for debug purpose to expose the set of > features negotiated with guest. The patch exports those features via > read-only bit properties. > > This patchset is a proof-of-concept on a base of virtio network device. > > Signed-off-by: Denis V. Lunev > CC: Michael S. Tsirkin > CC: Eric Blake > > Denis V. Lunev (2): > qdev: add read-only bit/bit64 property > virtio: show features acked by guest in 'info qtree' dump > > hw/core/qdev-properties.c | 29 +++++++++++++++++++++++++++-- > hw/net/virtio-net.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > include/hw/qdev-properties.h | 18 ++++++++++++++++++ > 3 files changed, 89 insertions(+), 2 deletions(-) > alternatively, we can define new property type, which will set bit in one place and shows the value of two bits. Any suggestion would be welcome. Den