From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0md5-0002S6-7h for qemu-devel@nongnu.org; Thu, 12 May 2016 05:10:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0md0-0007LZ-Sw for qemu-devel@nongnu.org; Thu, 12 May 2016 05:09:58 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:35663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0md0-0007LI-N0 for qemu-devel@nongnu.org; Thu, 12 May 2016 05:09:54 -0400 Received: by mail-pf0-x243.google.com with SMTP id r187so6954523pfr.2 for ; Thu, 12 May 2016 02:09:54 -0700 (PDT) References: <1462282457-24574-1-git-send-email-ashijeetacharya@gmail.com> <20160503140114.GA11694@redhat.com> <5728EA66.3040909@gmail.com> <20160504083913.GC31167@redhat.com> From: Ashi Message-ID: <5734485E.2000006@gmail.com> Date: Thu, 12 May 2016 14:39:50 +0530 MIME-Version: 1.0 In-Reply-To: <20160504083913.GC31167@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Modify net/socket.c to use functions from include/qemu/sockets.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: jasowang@redhat.com, qemu-devel@nongnu.org On Wednesday 04 May 2016 02:09 PM, Daniel P. Berrange wrote: > On Tue, May 03, 2016 at 11:43:58PM +0530, Ashi wrote: >> >> >> On Tuesday 03 May 2016 07:31 PM, Daniel P. Berrange wrote: >>> On Tue, May 03, 2016 at 07:04:17PM +0530, Ashijeet Acharya wrote: >>>> From: Ashijeet >>>> >>>> Replaced connect()/listen()/parse_host_port() in net/socket.c >>>> with inet_connect()/inet_listen/inet_parse() in include/qemu/sockets.h. >>> >>> If you're going to re-work this, then I think it'd be better to >>> go straight to using socket_connect() / socket_listen() / socket_parse() >>> which are QAPI based. The inet_* function should eventually be going >>> away once everything is using the QAPI based socket_* functions, so >>> adding more usage of them is not too desirable. >>> >> >> Yeah sure I can do that. Also I was wondering if there is a similar function >> for bind because the task listed on wiki BiteSized also expects replacement >> of bind(). So maybe adding/defining socket_bind() in util/qemu-sockets.c and >> the header include/qemu/sockets.h be helpful. > > bind() is done automatically as part of the socket_listen() function Well, I have completed replacing all the older functions with new QAPI based socket_*() ones. Although I am stuck at a part which uses snprintf() in net_socket_connect_init() function (line no. 605). The inet_ntoa() and ntohs() used in snprintf() are really bugging me as I am not sure how to use them with the new SocketAddress type sockets. The code compiles without snprintf() but I am not sure what effect does it have as a whole to abort snprintf(). I am not sure what to do with that?? Thanks! Ashijeet > > Regards, > Daniel >