From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0shg-0005UX-5z for qemu-devel@nongnu.org; Thu, 12 May 2016 11:39:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0shd-0003tZ-Ms for qemu-devel@nongnu.org; Thu, 12 May 2016 11:39:07 -0400 References: <1463006384-7734-1-git-send-email-eblake@redhat.com> <1463006384-7734-10-git-send-email-eblake@redhat.com> <20160512074730.GA20947@redhat.com> From: Eric Blake Message-ID: <5734A392.4000804@redhat.com> Date: Thu, 12 May 2016 09:38:58 -0600 MIME-Version: 1.0 In-Reply-To: <20160512074730.GA20947@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NBkdviP48xUGOsR06HlS6DCjHO7jS8HaS" Subject: Re: [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Kevin Wolf , pbonzini@redhat.com, alex@alex.org.uk, qemu-block@nongnu.org, Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NBkdviP48xUGOsR06HlS6DCjHO7jS8HaS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2016 01:47 AM, Daniel P. Berrange wrote: > On Wed, May 11, 2016 at 04:39:42PM -0600, Eric Blake wrote: >> The NBD protocol allows servers to advertise a human-readable >> description alongside an export name during NBD_OPT_LIST. Add >> an option to pass through the user's string to the NBD client. >> >> Doing this also makes it easier to test commit 200650d4, which >> is the client counterpart of receiving the description. >> >> -@item -x NAME, --export-name=3DNAME >> +@item -x, --export-name=3D@var{name} >=20 > Why this change - that reads as saying that '-x' doesn't take any value= > which is wrong IMHO It's consistent with other options-with-arguments in the same file, such = as: @item -p, --port=3D@var{port} @item -o, --offset=3D@var{offset} @item -b, --bind=3D@var{iface} @item -k, --socket=3D@var{path} etc. Basically, we want to use this common escape hatch (see 'ls --help', for example): Mandatory arguments to long options are mandatory for short options too. >> +@item -D, --description=3D@var{description} >=20 > Likewise this suggests -D doesn't take a value If you don't like it, then we should have a separate patch for the entire file should switch over to: @item -D @var{description}, --description=3D@var{description} style, where the mandatory option is listed for both option spellings for every affected option. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NBkdviP48xUGOsR06HlS6DCjHO7jS8HaS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXNKOSAAoJEKeha0olJ0NqT3EH+wRncPRd498y112X8FavDG4p YaZ2za3UIjUtomMi8TS5eK6/uG0bQSKvC7bl7FUDjFMzkBWpiO+nge27P4ULpHu1 YP/VYk74L1wXVMFkEi8ckuBtgtUr3vxj7DE5Q/Nna2Z6i7SNWPOVIi8rwfpjjOWh CzbTowDjjmZTQsqC11x1tw+FCTstJNmn+9vQ0VrF0iGOKodtFbo1NiRCYYW63Ue2 UkYJDHOOsX8M8ftInx5e22dxeHldJ2DKLEhn1q4moluY+i9TGUm1akdgGukv4jHw 2r6xXRMgeVy6eOwSMIfs6838pxruwYQQxcaqLCUOnr44KNk2d60Vqi56mDBE6jc= =O8ta -----END PGP SIGNATURE----- --NBkdviP48xUGOsR06HlS6DCjHO7jS8HaS--