From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0sss-0005fH-5p for qemu-devel@nongnu.org; Thu, 12 May 2016 11:50:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0ssp-0006s3-M8 for qemu-devel@nongnu.org; Thu, 12 May 2016 11:50:41 -0400 References: <1462677405-4752-1-git-send-email-eblake@redhat.com> <1462677405-4752-5-git-send-email-eblake@redhat.com> <20160512143822.GE4794@noname.redhat.com> From: Eric Blake Message-ID: <5734A646.3080100@redhat.com> Date: Thu, 12 May 2016 09:50:30 -0600 MIME-Version: 1.0 In-Reply-To: <20160512143822.GE4794@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kspbkP99G0WMlsiad756HNcePan6jDkCI" Subject: Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kspbkP99G0WMlsiad756HNcePan6jDkCI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2016 08:38 AM, Kevin Wolf wrote: > Am 08.05.2016 um 05:16 hat Eric Blake geschrieben: >> There's no reason to require the user to specify a flag just so >> they can pass in unaligned numbers. Keep 'read -p' and 'write -p' >> as no-ops so that I don't have to hunt down and update all users >> of qemu-io, but otherwise make their behavior default as 'read' and >> 'write'. Also fix 'write -z', 'readv', 'writev', 'writev', >> 'aio_read', 'aio_write', and 'aio_write -z'. For now, 'read -b', >> 'write -b', and 'write -c' still require alignment (and 'multiwrite', >> but that's slated to die soon). >> >> qemu-iotest 23 is updated to match, as the only test that was >> previously explicitly expecting an error on an unaligned request. I found that one by 'git grep "sector aligned"', and tested with ./check -qcow2... >> >> Signed-off-by: Eric Blake >=20 > This breaks qemu-iotests 136 for raw. It's pretty obvious that this is = a > test case problem (uses unaligned requests to test error accounting), s= o > I'm not dropping the patch, but please do send a follow-up. =2E..which explains why I missed this failure with ./check -raw. Will fix, and maybe I should have grepped a bit harder, since it is fairly obvious: tests/qemu-iotests/136: # Two types of invalid operations: unaligned length and unaligned offset I will also check if this needs updating: tests/qemu-iotests/109: # qemu-img compare can't handle unaligned file sizes as both of those tests run under -raw but not -qcow2 >=20 > Maybe negative length and offset work as a replacement. Indeed, since unaligned length and unaligned offset are now explicitly handled by the block layer. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kspbkP99G0WMlsiad756HNcePan6jDkCI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXNKZGAAoJEKeha0olJ0NqC8EH/3nhkwZzG8TuLegQ9XHeOdUn nbhu2d4vANhytewDog/IvWvgR2OhpjvCKrE8bcBlIEuBgM8VUXPMOuVPHLuzlIb/ t2BsnM6roO2o4foZUOrD0LVA8zafTwmomOTRbT6OJKMa7Q1DFm+ERrbsYFY0IKss p76g7priJZU3bKWU3RmKQ2x2OrBMp1FSFJJw3SrxY9UhtRuiCcHNyFZOSbNSSInt 6H3g04Fg/+dp4CcaDTtrMETJz7pHPhI0rXQ/EO74+bxUB2cp6RfxfsrFBDZX+dy4 V0xURLPUmKVuKmdSbCmiMrXE8CpbCZsfc04g6F6wRed4kC7GuU4GUQpRoovFP3c= =/uLb -----END PGP SIGNATURE----- --kspbkP99G0WMlsiad756HNcePan6jDkCI--