qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, armbru@redhat.com,
	crosthwaitepeter@gmail.com, cov@codeaurora.org,
	pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v5 3/3] docs: Add a generic loader explanation document
Date: Thu, 12 May 2016 10:24:44 -0600	[thread overview]
Message-ID: <5734AE4C.7040804@redhat.com> (raw)
In-Reply-To: <723eb07ff8e7b7c64cede2f2e48452138541abc6.1463069453.git.alistair.francis@xilinx.com>

[-- Attachment #1: Type: text/plain, Size: 2066 bytes --]

On 05/12/2016 10:13 AM, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> V4:
>  - Re-write to be more comprehensive
> 
>  docs/generic-loader.txt | 56 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 docs/generic-loader.txt

> +Loading Memory Values
> +---------------------------

Worth matching ---- line length to the line above?

> +
> +NOTE: The loader device supports other options (see the next section) but they
> +      do not apply to setting memory values and will be ignored.

Ignoring invalid option combinations is not as friendly as outright
rejecting them.


> +
> +Loading Files
> +---------------------------

And again

> +The loader device also allows files to be loaded into memory. This can be done
> +similarly to setting memory values. The syntax is shown below:
> +
> +    -device loader,file=<file>,addr=<addr>,cpu-num=<cpu-num>,force-raw=<raw>
> +
> +    <file>      - A file to be loaded into memory
> +    <addr>      - The addr in memory that the file should be loaded. This is
> +                  ignored if you are using an ELF (unless force-raw is true).
> +                  This is requried if you aren't loading an ELF.

s/requried/required/

> +    <cpu-num>   - This specifices the CPU that should be used. This is an

s/specifices/specifies/

> +                  optional argument and will cause the CPU's PC to be set to
> +                  where the image is stored. This option should only be used
> +                  for the boot image.
> +    <force-raw> - Forces the file to be treated as a raw image. This can be
> +                  used to specificy the load address of ELF files.

s/specificy/specify/

> +
> +An example of loading an ELF file which CPU0 will boot is shown below:
> +    -device loader,file=./images/boot.elf,cpu-num=0
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2016-05-12 16:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 16:13 [Qemu-devel] [PATCH v5 0/3] Add a generic loader Alistair Francis
2016-05-12 16:13 ` [Qemu-devel] [PATCH v5 1/3] loader: Allow ELF loader to auto-detect the ELF arch Alistair Francis
2016-05-12 16:13 ` [Qemu-devel] [PATCH v5 2/3] generic-loader: Add a generic loader Alistair Francis
2016-05-12 16:13 ` [Qemu-devel] [PATCH v5 3/3] docs: Add a generic loader explanation document Alistair Francis
2016-05-12 16:24   ` Eric Blake [this message]
2016-05-12 17:58     ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5734AE4C.7040804@redhat.com \
    --to=eblake@redhat.com \
    --cc=afaerber@suse.de \
    --cc=alistair.francis@xilinx.com \
    --cc=armbru@redhat.com \
    --cc=cov@codeaurora.org \
    --cc=crosthwaitepeter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).