From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b0tnW-0005qm-7w
	for qemu-devel@nongnu.org; Thu, 12 May 2016 12:49:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b0tnS-0005Sa-1R
	for qemu-devel@nongnu.org; Thu, 12 May 2016 12:49:14 -0400
Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:33561)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b0tnR-0005SL-Q4
	for qemu-devel@nongnu.org; Thu, 12 May 2016 12:49:09 -0400
Received: by mail-lf0-x241.google.com with SMTP id j8so8293445lfd.0
	for <qemu-devel@nongnu.org>; Thu, 12 May 2016 09:49:09 -0700 (PDT)
References: <1463062461-717-1-git-send-email-sergey.fedorov@linaro.org>
	<ad9956e9-d65c-eb57-2860-66aca193c89a@twiddle.net>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <5734B402.4050405@gmail.com>
Date: Thu, 12 May 2016 19:49:06 +0300
MIME-Version: 1.0
In-Reply-To: <ad9956e9-d65c-eb57-2860-66aca193c89a@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Clean up 'interrupt_request'
 reloading in cpu_handle_interrupt()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Sergey Fedorov <sergey.fedorov@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 12/05/16 19:47, Richard Henderson wrote:
> On 05/12/2016 04:14 AM, Sergey Fedorov wrote:
>> @@ -489,9 +489,10 @@ static inline void cpu_handle_interrupt(CPUState
>> *cpu,
>>                  *last_tb = NULL;
>>              }
>
> [A]
>
>>          }
>> -        /* Don't use the cached interrupt_request value,
>> -           do_interrupt may have updated the EXITTB flag. */
>> -        if (cpu->interrupt_request & CPU_INTERRUPT_EXITTB) {
>> +        /* The target hook may have updated the
>> 'cpu->interrupt_request';
>> +         * reload the 'interrupt_request' value */
>> +        interrupt_request = cpu->interrupt_request;
>> +        if (interrupt_request & CPU_INTERRUPT_EXITTB) {
>
> Actually I suggested reloading it after the only place it could have
> changed, at A.

Oops :) Will fix it and resend.

Thanks,
Sergey