From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0xKW-0005p8-4P for qemu-devel@nongnu.org; Thu, 12 May 2016 16:35:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0xKT-0007CR-PG for qemu-devel@nongnu.org; Thu, 12 May 2016 16:35:30 -0400 References: <1456747261-22032-1-git-send-email-berrange@redhat.com> <1456747261-22032-25-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <5734E90A.2040805@redhat.com> Date: Thu, 12 May 2016 14:35:22 -0600 MIME-Version: 1.0 In-Reply-To: <1456747261-22032-25-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xdd4Vimhoc4jsfRHLwljvDjAuW2KSX3bM" Subject: Re: [Qemu-devel] [PATCH v4 24/26] block: rip out all traces of password prompting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Fam Zheng This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xdd4Vimhoc4jsfRHLwljvDjAuW2KSX3bM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/29/2016 05:00 AM, Daniel P. Berrange wrote: > Now that qcow & qcow2 are wired up to get encryption keys > via the QCryptoSecret object, nothing is relying on the > interactive prompting for passwords. All the code related > to password prompting can thus be ripped out. >=20 > Signed-off-by: Daniel P. Berrange > --- > hmp.c | 31 --------------------- > hw/usb/dev-storage.c | 34 ------------------------ > include/monitor/monitor.h | 7 ----- > include/qemu/osdep.h | 2 -- > monitor.c | 68 ---------------------------------------= -------- > qemu-img.c | 31 --------------------- > qemu-io.c | 21 --------------- > qmp.c | 10 +------ > tests/qemu-iotests/087 | 2 ++ > util/oslib-posix.c | 66 ---------------------------------------= ------ > util/oslib-win32.c | 24 ----------------- > 11 files changed, 3 insertions(+), 293 deletions(-) Missed a spot: in qapi-schema.json, human-monitor-command states: # Notes: This command only exists as a stop-gap. Its use is highly # discouraged. The semantics of this command are not guaranteed. =2E.. # o Commands that prompt the user for data (eg. 'cont' when the blo= ck # device is encrypted) don't currently work but after your series, cont no longer prompts for passwords so the comment is (or will be) stale and worth removing. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xdd4Vimhoc4jsfRHLwljvDjAuW2KSX3bM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXNOkKAAoJEKeha0olJ0NqrTsH/jBDrOOrxWmZjZPlFMa+kzIc 1SqQQCwplmkRf2pNh44g2CT3iVUN5wX/XQdV3LZQoSl9diSa59QV7H0f+rvMVA9W Iy+0vzYyhJ9ouG8Ys+6b/wtyaZSK6HHdUWRCqn/6vk9X7TNgSkf8PchSEgF15Vs9 M/zkvjdGrVbIm1sOTLJYuHKEJu3DlglTeLYu3TgPof+BlqAM5YIlxHlwULnVJ+m8 gz67jGQrOdztkQ//CAgCkNLaidmyZmQGi4FYgChsUQwMmIkwhBCso8r5V+8OLPbK QuefVOn70Rx5SWtQkVYYIyvpP8x0kIkIwVq9XlLUbFFaHdYkdDJ/aigDl2AymQo= =wgCN -----END PGP SIGNATURE----- --xdd4Vimhoc4jsfRHLwljvDjAuW2KSX3bM--