From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1EWn-0005ul-W8 for qemu-devel@nongnu.org; Fri, 13 May 2016 10:57:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1EWl-0000FT-O9 for qemu-devel@nongnu.org; Fri, 13 May 2016 10:57:20 -0400 References: <1462354765-14037-1-git-send-email-kwolf@redhat.com> <1462354765-14037-8-git-send-email-kwolf@redhat.com> <0ae2b471-a304-4bdd-e72f-78bca544c279@redhat.com> From: Eric Blake Message-ID: <5735EB46.2010004@redhat.com> Date: Fri, 13 May 2016 08:57:10 -0600 MIME-Version: 1.0 In-Reply-To: <0ae2b471-a304-4bdd-e72f-78bca544c279@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D1mvF8P6mDauKbMvK1u7usVj0UbU8T8lR" Subject: Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, jcody@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D1mvF8P6mDauKbMvK1u7usVj0UbU8T8lR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/13/2016 08:38 AM, Max Reitz wrote: > On 04.05.2016 11:39, Kevin Wolf wrote: >> This changes the mirror block job to use the job's BlockBackend for >> performing its I/O. job->bs isn't used by the mirroring code any more >> afterwards. >> >> Signed-off-by: Kevin Wolf >> --- >> @@ -156,8 +156,8 @@ static void mirror_read_complete(void *opaque, int= ret) >> mirror_iteration_done(op, ret); >> return; >> } >> - bdrv_aio_writev(s->target, op->sector_num, &op->qiov, op->nb_sect= ors, >> - mirror_write_complete, op); >> + blk_aio_writev(s->target, op->sector_num, &op->qiov, op->nb_secto= rs, >> + mirror_write_complete, op); >=20 > Or maybe the rest doesn't look so good after all. We don't have this > function anymore, I'm afraid. Relatively mechanical conversion to blk_aio_pwritev(s->target, op->sector_num << BDRV_SECTOR_BITS, &op->qiov, 0, mirror_write_complete, op) although switching away from sectors to bytes in general is a bigger clea= nup --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --D1mvF8P6mDauKbMvK1u7usVj0UbU8T8lR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXNetGAAoJEKeha0olJ0Nqd1kH/0M8OQNjBPwp+54b7JkCTcjL 5weLjzJXPEYWSOyokHEl0zuAFfJbTmzbsWUpNrxtvv/uwh1ycUxgiIpNzYVhAL/p 1Tc+dD5teU7iHFU6Gqn5QTkljSqwlAtKNyziJ8eV4mkOUWqxlzLqxhNiL/LvdHl1 T4ZaOWRSKKFwwt6KKxLNmXozvgCl37f2n7ufNfT43pReDML9WcV4XRPYG9VWQlzn 3m1CPT2uAaa9M65gW0O3XG/To3YCxQ/D7hesHBtTMep/qAJ4XX1onpDPPOqa7gLJ 9ht0dtauR+b03RkK249Q1MHU+t4rHVGIIA5KwOdmXq2g2Vqud+d4obGOMOjhWng= =pvDE -----END PGP SIGNATURE----- --D1mvF8P6mDauKbMvK1u7usVj0UbU8T8lR--