From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50741)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1b1voA-00007D-Mf
	for qemu-devel@nongnu.org; Sun, 15 May 2016 09:10:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1b1vo5-0001Gp-KZ
	for qemu-devel@nongnu.org; Sun, 15 May 2016 09:10:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34794)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1b1vo5-0001GR-FW
	for qemu-devel@nongnu.org; Sun, 15 May 2016 09:10:05 -0400
References: <1462508442-9407-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<1462508442-9407-11-git-send-email-caoj.fnst@cn.fujitsu.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <57387529.5060203@redhat.com>
Date: Sun, 15 May 2016 16:10:01 +0300
MIME-Version: 1.0
In-Reply-To: <1462508442-9407-11-git-send-email-caoj.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add
 capability
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>

On 05/06/2016 07:20 AM, Cao jin wrote:
> ENOSPC is programming error, assert it for debugging.
>
> cc: Michael S. Tsirkin <mst@redhat.com>
> cc: Marcel Apfelbaum <marcel@redhat.com>
> cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>   hw/pci/pci.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index f0f41dc..fc8b377 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -2151,10 +2151,8 @@ int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id,
>
>       if (!offset) {
>           offset = pci_find_space(pdev, size);
> -        if (!offset) {
> -            error_setg(errp, "out of PCI config space");
> -            return -ENOSPC;
> -        }
> +        /* out of PCI config space should be programming error */

'is', not 'should be'

> +        assert(offset);
>       } else {
>           /* Verify that capabilities don't overlap.  Note: device assignment
>            * depends on this check to verify that the device is not broken.
>

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Thanks,
Marcel