From: "Denis V. Lunev" <den@openvz.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io
Date: Mon, 16 May 2016 16:21:57 +0300 [thread overview]
Message-ID: <5739C975.107@openvz.org> (raw)
In-Reply-To: <5739C693.3070007@redhat.com>
On 05/16/2016 04:09 PM, Paolo Bonzini wrote:
>
> On 14/05/2016 14:01, Denis V. Lunev wrote:
>> It would be convinient to enable tracepoints in qemu-io binary. This would
>> allow to perform investigations without additional code recompilations.
>>
>> The command line will be exactly the same as in qemu-system.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Kevin Wolf <kwolf@redhat.com>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> qemu-io.c | 43 +++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 43 insertions(+)
>>
>> diff --git a/qemu-io.c b/qemu-io.c
>> index 5ef3ef7..2d0d2b0 100644
>> --- a/qemu-io.c
>> +++ b/qemu-io.c
>> @@ -18,6 +18,7 @@
>> #include "qemu/option.h"
>> #include "qemu/config-file.h"
>> #include "qemu/readline.h"
>> +#include "qemu/log.h"
> Why does this need qemu/log.h, as opposed to trace/control.h (which
> probably should be moved to include/qemu/trace.h, but that's a patch for
> another day)?
no, this is necessary for qemu_set_log(LOG_TRACE); which is performed
as a last
step to enable tracing.
next prev parent reply other threads:[~2016-05-16 13:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 12:01 [Qemu-devel] [PATCH 0/6] qcow2_co_write_zeroes and related improvements Denis V. Lunev
2016-05-14 12:01 ` [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io Denis V. Lunev
2016-05-16 13:09 ` Paolo Bonzini
2016-05-16 13:21 ` Denis V. Lunev [this message]
2016-05-16 16:07 ` Eric Blake
2016-05-14 12:01 ` [Qemu-devel] [PATCH 2/6] block: split write_zeroes always Denis V. Lunev
2016-05-16 16:13 ` Eric Blake
2016-05-14 12:01 ` [Qemu-devel] [PATCH 3/6] qcow2: simplify logic in qcow2_co_write_zeroes Denis V. Lunev
2016-05-16 16:28 ` Eric Blake
2016-05-14 12:01 ` [Qemu-devel] [PATCH 4/6] qcow2: add tracepoints for qcow2_co_write_zeroes Denis V. Lunev
2016-05-16 16:32 ` Eric Blake
2016-05-16 16:48 ` Denis V. Lunev
2016-05-14 12:01 ` [Qemu-devel] [PATCH 5/6] qcow2: fix condition in is_zero_cluster Denis V. Lunev
2016-05-14 12:01 ` [Qemu-devel] [PATCH 6/6] qcow2: merge is_zero_cluster helpers into qcow2_co_write_zeroes Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739C975.107@openvz.org \
--to=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).