From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60225)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1b2Ii6-0004TS-LH
	for qemu-devel@nongnu.org; Mon, 16 May 2016 09:37:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1b2Ii1-00072U-JH
	for qemu-devel@nongnu.org; Mon, 16 May 2016 09:37:26 -0400
Received: from mail-am1on0143.outbound.protection.outlook.com
	([157.56.112.143]:42086
	helo=emea01-am1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1b2Ii1-00072K-3a
	for qemu-devel@nongnu.org; Mon, 16 May 2016 09:37:21 -0400
References: <1463227273-27523-1-git-send-email-den@openvz.org>
	<1463227273-27523-2-git-send-email-den@openvz.org>
	<5739C693.3070007@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <5739C975.107@openvz.org>
Date: Mon, 16 May 2016 16:21:57 +0300
MIME-Version: 1.0
In-Reply-To: <5739C693.3070007@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>

On 05/16/2016 04:09 PM, Paolo Bonzini wrote:
>
> On 14/05/2016 14:01, Denis V. Lunev wrote:
>> It would be convinient to enable tracepoints in qemu-io binary. This would
>> allow to perform investigations without additional code recompilations.
>>
>> The command line will be exactly the same as in qemu-system.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Kevin Wolf <kwolf@redhat.com>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>   qemu-io.c | 43 +++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 43 insertions(+)
>>
>> diff --git a/qemu-io.c b/qemu-io.c
>> index 5ef3ef7..2d0d2b0 100644
>> --- a/qemu-io.c
>> +++ b/qemu-io.c
>> @@ -18,6 +18,7 @@
>>   #include "qemu/option.h"
>>   #include "qemu/config-file.h"
>>   #include "qemu/readline.h"
>> +#include "qemu/log.h"
> Why does this need qemu/log.h, as opposed to trace/control.h (which
> probably should be moved to include/qemu/trace.h, but that's a patch for
> another day)?
no, this is necessary for  qemu_set_log(LOG_TRACE); which is performed 
as a last
step to enable tracing.