From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization code
Date: Mon, 16 May 2016 16:25:48 +0200 [thread overview]
Message-ID: <5739D86C.6070309@redhat.com> (raw)
In-Reply-To: <20160512170408.GN4457@thinpad.lan.raisama.net>
On 12/05/2016 19:04, Eduardo Habkost wrote:
>>> This changes some initialization code in vl.c, qemu-img, qemu-io,
>>> > > and qemu-nbd to use &error_fatal instead of manual error
>>> > > checking/reporting.
>>> > >
>>> > > The series is based on my machine branch, available at:
>>> > > git://github.com/ehabkost/qemu.git machine
>> >
>> > Patches 1-2-6 are obvious.
> Thanks. I will apply 1-2 to my machine branch. Should I apply
> patch 6, too?
Yes, please.
>> > I'm not sure about 3-4-5, these are internal functions where the error
>> > is somewhere below "should never happen" (&error_abort)---it actually
>> > should never happen, but exiting due to SIGABRT sounds wrong. It's not
>> > the kind of function that I'd expect to have an Error** argument...
> Assuming you still want to keep the Error** argument in
> qemu_init_main_loop(), I can send a simpler patch that doesn't
> touch qemu_signal_init().
Sure, that's good!
Paolo
prev parent reply other threads:[~2016-05-16 14:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 14:09 [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization code Eduardo Habkost
2016-05-12 14:09 ` [Qemu-devel] [PATCH 1/6] vl: Use &error_fatal when parsing VNC options Eduardo Habkost
2016-05-12 14:10 ` [Qemu-devel] [PATCH 2/6] vl: Use &error_fatal when parsing monitor options Eduardo Habkost
2016-05-12 14:10 ` [Qemu-devel] [PATCH 3/6] main-loop: Use Error** to report qemu_signal_init() errors Eduardo Habkost
2016-05-12 14:10 ` [Qemu-devel] [PATCH 4/6] main-loop: Use &error_fatal when calling qemu_init_main_loop() Eduardo Habkost
2016-05-12 14:10 ` [Qemu-devel] [PATCH 5/6] main-loop: Make qemu_init_main_loop() and qemu_signal_init() void Eduardo Habkost
2016-05-12 14:10 ` [Qemu-devel] [PATCH 6/6] Use &error_fatal when initializing crypto on qemu-{img, io, nbd} Eduardo Habkost
2016-05-12 16:48 ` [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization code Paolo Bonzini
2016-05-12 17:04 ` Eduardo Habkost
2016-05-16 14:25 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739D86C.6070309@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).