From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2L3k-0008PH-Tt for qemu-devel@nongnu.org; Mon, 16 May 2016 12:07:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2L3g-0005JG-Ai for qemu-devel@nongnu.org; Mon, 16 May 2016 12:07:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2L3f-0005JB-VT for qemu-devel@nongnu.org; Mon, 16 May 2016 12:07:52 -0400 References: <1463227273-27523-1-git-send-email-den@openvz.org> <1463227273-27523-2-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <5739F056.5080404@redhat.com> Date: Mon, 16 May 2016 10:07:50 -0600 MIME-Version: 1.0 In-Reply-To: <1463227273-27523-2-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lsI10wrrhOr175dRV6Nol7ePq98qp6tsM" Subject: Re: [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lsI10wrrhOr175dRV6Nol7ePq98qp6tsM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/14/2016 06:01 AM, Denis V. Lunev wrote: > It would be convinient to enable tracepoints in qemu-io binary. This wo= uld s/convinient/convenient/ > allow to perform investigations without additional code recompilations.= >=20 > The command line will be exactly the same as in qemu-system. Reads awkwardly. Grammar suggestion for the whole commit body: For convenience, enable tracepoints in the qemu-io binary just like what is done for qemu-system. This allows trace investigations without additional code recompilation. >=20 > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Paolo Bonzini > --- > qemu-io.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lsI10wrrhOr175dRV6Nol7ePq98qp6tsM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXOfBWAAoJEKeha0olJ0Nq8kEH/0E+6upXO/UhUrqtawPngBo5 KzWkETy4uESz4aRVp486MBjCf1JxZj6JqE7HIdCyh6UUtphc4UWz8niBKrz7Q1rE yTDvbXfg6ufrp9Ah3oHK2I/rqtpIeRvxA4CHgJ59zYtzVLjsTGRbZhqSOn7lzVUr y6RQtWlqia+7z6KRWTVTCs3pehkebMjQF6rbFqVHor7/m1/C8gMbQ7hhtCs0fneU XWztaX121xjkqPGlH6/xzq2HNqgSSZkdkwzStMnKKn545WbhXA3dzrDlY4H/+MqK dfOKoNW2CwvIc2yM9A1LV2QqrMZfgKUnwKkLZhP80pEza6pL5tdzclS/o3LuAmM= =E0Um -----END PGP SIGNATURE----- --lsI10wrrhOr175dRV6Nol7ePq98qp6tsM--