From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2LPt-0006uj-2p for qemu-devel@nongnu.org; Mon, 16 May 2016 12:30:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2LPm-0002sW-NN for qemu-devel@nongnu.org; Mon, 16 May 2016 12:30:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2LPm-0002sS-Hd for qemu-devel@nongnu.org; Mon, 16 May 2016 12:30:42 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 23D6DC05B1C8 for ; Mon, 16 May 2016 16:30:42 +0000 (UTC) References: <1463412982-6681-1-git-send-email-pbonzini@redhat.com> <1463412982-6681-2-git-send-email-pbonzini@redhat.com> <5739F35C.6030000@redhat.com> <5739F485.6030101@redhat.com> From: Eric Blake Message-ID: <5739F5B1.6060408@redhat.com> Date: Mon, 16 May 2016 10:30:41 -0600 MIME-Version: 1.0 In-Reply-To: <5739F485.6030101@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OhOwwvnRWdECJh6UavOrrNpsUqtIx42nj" Subject: Re: [Qemu-devel] [PATCH 01/50] scripts: add script to build QEMU and analyze inclusions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OhOwwvnRWdECJh6UavOrrNpsUqtIx42nj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/16/2016 10:25 AM, Paolo Bonzini wrote: >=20 >=20 > On 16/05/2016 18:20, Eric Blake wrote: >>> +QEMU_CFLAGS=3D$(sed -n s/^QEMU_CFLAGS=3D//p config-host.mak) >>> +QEMU_INCLUDES=3D$(sed -n s/^QEMU_INCLUDES=3D//p config-host.mak | \ >>> + sed 's/$(SRC_PATH)/../g' ) >> >> Could avoid a 'sed | sed' by doing: >> >> QEMU_INCLUDES=3D$(sed -n '/^QEMU_INCLUDES=3D/ s/$(SRC_PATH)/../gp' \ >> config-host.mak) >> >=20 > Not quite, I'm removing the "QEMU_INCLUDES=3D" part even if it doesn't > match $(SRC_PATH). Serves me write for not testing. QEMU_INCLUDES=3D$(sed -n '/^QEMU_INCLUDES=3D/ { s///; s/$(SRC_PATH)/../g;= p }' config-host.mak) at which point maybe yours is more legible after all (especially since there are portability worries about {} used without newlines). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OhOwwvnRWdECJh6UavOrrNpsUqtIx42nj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXOfWxAAoJEKeha0olJ0NqQGMH/jJlLg5P1A2AL/t7jXNIpEds wfKRQo7TXMzmD6GAV3WWe44buhDKPFycKviZEo6A7LgWVob/PXhKy2IeMpOFgqpb V9PcFW4eBnsPa9qZv897ephF577z8K94p1OY8EnKmd6dCTmCZx5k8/24FXv4stho 9BHIn4jiMO5UVc2G9MzSA5HsbNfspV2ZuFKLXxru+Jp7yL9PVxIJhLS6m4akd0+u FlGSamNHzmjWeLLntYiUJmFvwRx3mywShRBZAoWlUKp0olkm6oHX80l7fpPEJ7Cf 6O8DInIPkU6rmupz1qKLDD/ngzEoe9gTRLiOPqRgGLgfKkR5gs3Lc6RMByrk2mM= =kuuI -----END PGP SIGNATURE----- --OhOwwvnRWdECJh6UavOrrNpsUqtIx42nj--