From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2LRZ-0008Uv-MO for qemu-devel@nongnu.org; Mon, 16 May 2016 12:32:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2LRV-0003IA-GA for qemu-devel@nongnu.org; Mon, 16 May 2016 12:32:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2LRV-0003I0-A3 for qemu-devel@nongnu.org; Mon, 16 May 2016 12:32:29 -0400 References: <1463227273-27523-1-git-send-email-den@openvz.org> <1463227273-27523-5-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <5739F61C.4050109@redhat.com> Date: Mon, 16 May 2016 10:32:28 -0600 MIME-Version: 1.0 In-Reply-To: <1463227273-27523-5-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HV87OAEdFNeVJET3B1lBQkRJxpBcRgpNt" Subject: Re: [Qemu-devel] [PATCH 4/6] qcow2: add tracepoints for qcow2_co_write_zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HV87OAEdFNeVJET3B1lBQkRJxpBcRgpNt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/14/2016 06:01 AM, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > --- > block/qcow2.c | 5 +++++ > trace-events | 2 ++ > 2 files changed, 7 insertions(+) >=20 > diff --git a/block/qcow2.c b/block/qcow2.c > index 9a54bbd..97bf870 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -2435,6 +2435,9 @@ static coroutine_fn int qcow2_co_write_zeroes(Blo= ckDriverState *bs, > int head =3D sector_num % s->cluster_sectors; > int tail =3D (sector_num + nb_sectors) % s->cluster_sectors; > =20 > + trace_qcow2_write_zeroes_start_req(qemu_coroutine_self(), sector_n= um, > + nb_sectors); > + Can we trace these by byte locations rather than by sector count? Ultimately, I think we want to move write_zeroes to a byte-based interface, even if we still assert internally that it is at least sector-aligned. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HV87OAEdFNeVJET3B1lBQkRJxpBcRgpNt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXOfYcAAoJEKeha0olJ0NqEC4H/jbn+5PQnb1zFebHBMVYTanV YkAoZ21qiWtwu4z3gOovc3KmfDwy4tH7JEn+1ucmJbQ1jMKxuoAL2R9Ftk+etRIv zTPHD3IuEvEvUgw7DK9QQ/8x8MfOqZ/SpZQw09zxsMCe+VZXnNUquo5vjABOTVXu rgsT7FG5cv633ZBiAL0zR6iuoPXB6LRAioTw1rkx/UeI+oOC5+qsK9uSMgjjsOO1 GSeOe3mp674Lg4aQRuSh0A0dn5nYrmzlnO1+yq/TJ7/06P5NNh/dVzczkj6kdkMi d45v8VyR9vH+nE1SG2eMRYC9cPuWlDY8a4na8Z7QZA6ZDIg/OkYATXwH0P2Pwe0= =3v6v -----END PGP SIGNATURE----- --HV87OAEdFNeVJET3B1lBQkRJxpBcRgpNt--