Re: [Qemu-devel] [PATCH 07/10] blockdev-backup: added support for data compression

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1835 bytes --]

On 05/14/2016 06:45 AM, Denis V. Lunev wrote:
> From: Pavel Butsykin <pbutsykin@virtuozzo.com>
> 
> The idea is simple - backup is "written-once" data. It is written block
> by block and it is large enough. It would be nice to save storage
> space and compress it.
> 

> +++ b/qapi/block-core.json
> @@ -941,6 +941,7 @@
>    'data': { 'device': 'str', 'target': 'str',
>              'sync': 'MirrorSyncMode',
>              '*speed': 'int',
> +            '*compress': 'bool',

Missing documentation.

>              '*on-source-error': 'BlockdevOnError',
>              '*on-target-error': 'BlockdevOnError' } }
>  
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 8915a0b..6eb5b43 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1241,7 +1241,7 @@ EQMP
>  
>      {
>          .name       = "blockdev-backup",
> -        .args_type  = "sync:s,device:B,target:B,speed:i?,"
> +        .args_type  = "sync:s,device:B,target:B,speed:i?,compress:b?,"
>                        "on-source-error:s?,on-target-error:s?",
>          .mhandler.cmd_new = qmp_marshal_blockdev_backup,
>      },
> @@ -1263,6 +1263,7 @@ Arguments:
>            sectors allocated in the topmost image, or "none" to only replicate
>            new I/O (MirrorSyncMode).
>  - "speed": the maximum speed, in bytes per second (json-int, optional)
> +- "compress": compress data blocks (if the target format supports it).

Missing mention that it is optional, default false.

>  - "on-source-error": the action to take on an error on the source, default
>                       'report'.  'stop' and 'enospc' can only be used
>                       if the block device supports io-status.
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]