From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2Lsb-0000qA-2n for qemu-devel@nongnu.org; Mon, 16 May 2016 13:00:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2LsU-0001J2-BC for qemu-devel@nongnu.org; Mon, 16 May 2016 13:00:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2LsU-0001Iv-3h for qemu-devel@nongnu.org; Mon, 16 May 2016 13:00:22 -0400 References: <1463229957-14253-1-git-send-email-den@openvz.org> <1463229957-14253-8-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <5739FCA4.6010800@redhat.com> Date: Mon, 16 May 2016 11:00:20 -0600 MIME-Version: 1.0 In-Reply-To: <1463229957-14253-8-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tWmk0LlT49BHp8HQG8fs1Gvl5STS1MkT0" Subject: Re: [Qemu-devel] [PATCH 07/10] blockdev-backup: added support for data compression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Pavel Butsykin , Jeff Cody , Markus Armbruster , John Snow , Stefan Hajnoczi , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tWmk0LlT49BHp8HQG8fs1Gvl5STS1MkT0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/14/2016 06:45 AM, Denis V. Lunev wrote: > From: Pavel Butsykin >=20 > The idea is simple - backup is "written-once" data. It is written block= > by block and it is large enough. It would be nice to save storage > space and compress it. >=20 > +++ b/qapi/block-core.json > @@ -941,6 +941,7 @@ > 'data': { 'device': 'str', 'target': 'str', > 'sync': 'MirrorSyncMode', > '*speed': 'int', > + '*compress': 'bool', Missing documentation. > '*on-source-error': 'BlockdevOnError', > '*on-target-error': 'BlockdevOnError' } } > =20 > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 8915a0b..6eb5b43 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -1241,7 +1241,7 @@ EQMP > =20 > { > .name =3D "blockdev-backup", > - .args_type =3D "sync:s,device:B,target:B,speed:i?," > + .args_type =3D "sync:s,device:B,target:B,speed:i?,compress:b?= ," > "on-source-error:s?,on-target-error:s?", > .mhandler.cmd_new =3D qmp_marshal_blockdev_backup, > }, > @@ -1263,6 +1263,7 @@ Arguments: > sectors allocated in the topmost image, or "none" to only re= plicate > new I/O (MirrorSyncMode). > - "speed": the maximum speed, in bytes per second (json-int, optional)= > +- "compress": compress data blocks (if the target format supports it).= Missing mention that it is optional, default false. > - "on-source-error": the action to take on an error on the source, def= ault > 'report'. 'stop' and 'enospc' can only be used > if the block device supports io-status. >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tWmk0LlT49BHp8HQG8fs1Gvl5STS1MkT0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXOfykAAoJEKeha0olJ0NqBp0H/2eDZs4lfRTgiYnRPXzOh+mu 04DlwT2XcBi2IDVHUy6qIIaREiG2Rdd2davHiP9aSswioN/JHRBrmUY2NvqZLkdJ yIVSMQIYhfIZPkOX0HEKA2Q2ZdobESWbV0mBhXpX1waU682X6Jh540oBiv8DTjH4 EYZZgevvElMmHrqqD1IWVAhQUOxeDDL2sMFT3hfjzr8ZJRR1XXDj8G1pMKc6LvNX nMhsYDu/aQqO34pEAkdRxsAhGj36B4DwoQuyCPJrtYelz21ANe/AEJkA4XWgaStN 1rbev4SJklRFKSrtyvtfedqUcozT4LjccK0+uni3FEYBMHpd/toYQW9/lNSrtV4= =dx7M -----END PGP SIGNATURE----- --tWmk0LlT49BHp8HQG8fs1Gvl5STS1MkT0--