From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Anton Johansson <anjo@rev.ng>,
Peter Maydell <peter.maydell@linaro.org>,
Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: Re: [PATCH-for-10.1 05/12] tcg: Use TCGContext::insn_start_words in tcg_gen_insn_start()
Date: Wed, 19 Mar 2025 09:19:17 -0700 [thread overview]
Message-ID: <5739e782-be27-4d64-b564-b7e07f5e616e@linaro.org> (raw)
In-Reply-To: <20250319134507.45045-6-philmd@linaro.org>
On 3/19/25 06:44, Philippe Mathieu-Daudé wrote:
> In tb_gen_code() we set TCGContext::insn_start_words to
> TARGET_INSN_START_WORDS:
>
> 290 TranslationBlock *tb_gen_code(...)
> 293 {
> ...
> 351 tcg_ctx->insn_start_words = TARGET_INSN_START_WORDS;
>
> This definition is expanded to:
>
> 11 # define TARGET_INSN_START_WORDS (1 + TARGET_INSN_START_EXTRA_WORDS)
>
> Directly use the identical tcg_ctx->insn_start_words variable.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/tcg/tcg-op.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Nack.
We are specializing the function signature to the number of arguments.
There is absolutely no point in reading that number from a variable.
r~
>
> diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h
> index e0038e70a8d..1f0d3b95304 100644
> --- a/include/tcg/tcg-op.h
> +++ b/include/tcg/tcg-op.h
> @@ -25,7 +25,7 @@
> #if TARGET_INSN_START_EXTRA_WORDS == 0
> static inline void tcg_gen_insn_start(uint64_t pc)
> {
> - unsigned insn_start_words = 1;
> + unsigned insn_start_words = tcg_ctx->insn_start_words;
> TCGOp *op = tcg_emit_op(INDEX_op_insn_start,
> insn_start_words * 64 / TCG_TARGET_REG_BITS);
>
> @@ -34,7 +34,7 @@ static inline void tcg_gen_insn_start(uint64_t pc)
> #elif TARGET_INSN_START_EXTRA_WORDS == 1
> static inline void tcg_gen_insn_start(uint64_t pc, uint64_t a1)
> {
> - unsigned insn_start_words = 1 + TARGET_INSN_START_EXTRA_WORDS;
> + unsigned insn_start_words = tcg_ctx->insn_start_words;
> TCGOp *op = tcg_emit_op(INDEX_op_insn_start,
> insn_start_words * 64 / TCG_TARGET_REG_BITS);
>
> @@ -44,7 +44,7 @@ static inline void tcg_gen_insn_start(uint64_t pc, uint64_t a1)
> #elif TARGET_INSN_START_EXTRA_WORDS == 2
> static inline void tcg_gen_insn_start(uint64_t pc, uint64_t a1, uint64_t a2)
> {
> - unsigned insn_start_words = 1 + TARGET_INSN_START_EXTRA_WORDS;
> + unsigned insn_start_words = tcg_ctx->insn_start_words;
> TCGOp *op = tcg_emit_op(INDEX_op_insn_start,
> insn_start_words * 64 / TCG_TARGET_REG_BITS);
>
next prev parent reply other threads:[~2025-03-19 16:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 13:44 [PATCH-for-10.1 00/12] tcg: Make tcg_gen_insn_start() target-agnostic Philippe Mathieu-Daudé
2025-03-19 13:44 ` [PATCH-for-10.1 01/12] tcg: Declare TARGET_INSN_START_EXTRA_WORDS in 'cpu-param.h' Philippe Mathieu-Daudé
2025-03-19 16:08 ` Richard Henderson
2025-03-19 13:44 ` [PATCH-for-10.1 02/12] tcg: Always define TARGET_INSN_START_EXTRA_WORDS Philippe Mathieu-Daudé
2025-03-19 16:09 ` Richard Henderson
2025-03-19 13:44 ` [PATCH-for-10.1 03/12] tcg: Have tcg_gen_insn_start() take uint64_t arguments Philippe Mathieu-Daudé
2025-03-19 16:16 ` Richard Henderson
2025-03-19 13:44 ` [PATCH-for-10.1 04/12] tcg: Declare local 'insn_start_words' variable in tcg_gen_insn_start() Philippe Mathieu-Daudé
2025-03-19 16:18 ` Richard Henderson
2025-03-19 13:44 ` [PATCH-for-10.1 05/12] tcg: Use TCGContext::insn_start_words " Philippe Mathieu-Daudé
2025-03-19 16:19 ` Richard Henderson [this message]
2025-03-19 13:45 ` [PATCH-for-10.1 06/12] tcg: Use TCGContext::insn_start_words in translate-all.c methods Philippe Mathieu-Daudé
2025-03-19 13:45 ` [PATCH-for-10.1 07/12] tcg: Check TARGET_INSN_START_EXTRA_WORDS range at runtime Philippe Mathieu-Daudé
2025-03-19 16:22 ` Richard Henderson
2025-03-19 13:45 ` [PATCH-for-10.1 08/12] tcg: Declare arrays using TARGET_INSN_START_WORDS_MAX Philippe Mathieu-Daudé
2025-03-19 13:45 ` [PATCH-for-10.1 09/12] tcg: Restrict TARGET_INSN_START_WORDS definition to translate-all.c Philippe Mathieu-Daudé
2025-03-19 13:45 ` [PATCH-for-10.1 10/12] tcg: Unify tcg_gen_insn_start() to handle 1 or 2 arguments Philippe Mathieu-Daudé
2025-03-19 16:37 ` Richard Henderson
2025-03-19 13:45 ` [PATCH-for-10.1 11/12] tcg: Unify tcg_gen_insn_start() to handle 0 " Philippe Mathieu-Daudé
2025-03-19 13:45 ` [PATCH-for-10.1 12/12] tcg: Uninline tcg_gen_insn_start() Philippe Mathieu-Daudé
2025-03-19 16:45 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739e782-be27-4d64-b564-b7e07f5e616e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anjo@rev.ng \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).