From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: Richard Henderson <rth@twiddle.net>, Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] cpus.c: Use pthread_sigmask() rather than sigprocmask()
Date: Tue, 17 May 2016 11:55:11 +0200 [thread overview]
Message-ID: <573AEA7F.2010201@redhat.com> (raw)
In-Reply-To: <CAFEAcA_WYS836+DJvB5Zj8=_6duY=GG2Ujg+aJFbdOynzGC7eg@mail.gmail.com>
On 16/05/2016 19:37, Peter Maydell wrote:
> The only other sigprocmask() uses are in linux-user, apart from
> a couple in net/tap.c, where they're used as part of forking and
> spawning the helper process. I suspect this should be using
> qemu_fork() instead of doing it all by hand, wrongly...
In all fairness those predate qemu_fork(). :)
Your patch also changes a Linux-only function, but it's cleaner to user
pthread_sigmask so I've queued it for the next pull request.
Paolo
prev parent reply other threads:[~2016-05-17 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 17:33 [Qemu-devel] [PATCH] cpus.c: Use pthread_sigmask() rather than sigprocmask() Peter Maydell
2016-05-16 17:37 ` Peter Maydell
2016-05-17 9:55 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573AEA7F.2010201@redhat.com \
--to=pbonzini@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).