From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2bim-000060-QN for qemu-devel@nongnu.org; Tue, 17 May 2016 05:55:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2bii-0005yX-Id for qemu-devel@nongnu.org; Tue, 17 May 2016 05:55:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2bii-0005yT-Cc for qemu-devel@nongnu.org; Tue, 17 May 2016 05:55:20 -0400 References: <1463420039-29761-1-git-send-email-peter.maydell@linaro.org> From: Paolo Bonzini Message-ID: <573AEA7F.2010201@redhat.com> Date: Tue, 17 May 2016 11:55:11 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpus.c: Use pthread_sigmask() rather than sigprocmask() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , QEMU Developers Cc: Richard Henderson , Patch Tracking On 16/05/2016 19:37, Peter Maydell wrote: > The only other sigprocmask() uses are in linux-user, apart from > a couple in net/tap.c, where they're used as part of forking and > spawning the helper process. I suspect this should be using > qemu_fork() instead of doing it all by hand, wrongly... In all fairness those predate qemu_fork(). :) Your patch also changes a Linux-only function, but it's cleaner to user pthread_sigmask so I've queued it for the next pull request. Paolo