From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43059)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1b2dhY-0007fY-Iv
	for qemu-devel@nongnu.org; Tue, 17 May 2016 08:02:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1b2dhT-0007hm-0b
	for qemu-devel@nongnu.org; Tue, 17 May 2016 08:02:16 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1463485084-21747-1-git-send-email-mreitz@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <573B083E.7020706@redhat.com>
Date: Tue, 17 May 2016 14:02:06 +0200
MIME-Version: 1.0
In-Reply-To: <1463485084-21747-1-git-send-email-mreitz@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block: Propagate AioContext change to all
 children
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>



On 17/05/2016 13:38, Max Reitz wrote:
> Instead of propagating any change of a BDS's AioContext only to its file
> and backing children and letting driver-specific code do the rest, just
> propagate it to all and drop the thus superfluous implementations of
> bdrv_{at,de}tach_aio_context() in Quorum, blkverify and VMDK.

See, young lad, when I was young we had no bs->children!

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>