From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2gqJ-0006sD-N2 for qemu-devel@nongnu.org; Tue, 17 May 2016 11:23:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2gqI-00013j-7d for qemu-devel@nongnu.org; Tue, 17 May 2016 11:23:31 -0400 References: <1463496094-21608-1-git-send-email-mreitz@redhat.com> <1463496094-21608-2-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <573B376B.4070003@redhat.com> Date: Tue, 17 May 2016 09:23:23 -0600 MIME-Version: 1.0 In-Reply-To: <1463496094-21608-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PMAWP1X3T84EOGM0aQgpALNvBkwDIBc7e" Subject: Re: [Qemu-devel] [PATCH v4 1/9] block: Drop useless bdrv_new() call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Alberto Garcia , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PMAWP1X3T84EOGM0aQgpALNvBkwDIBc7e Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/17/2016 08:41 AM, Max Reitz wrote: > bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS > before invoking bdrv_open() on that BDS. This is probably a relict from= s/relict/relic/ > when it used to do some modifications on that empty BDS, but now that i= s > unnecessary, so we can just set bs_snapshot to NULL and let bdrv_open()= > do the rest. >=20 > Signed-off-by: Max Reitz > Reviewed-by: Alberto Garcia > Reviewed-by: Kevin Wolf > --- > block.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PMAWP1X3T84EOGM0aQgpALNvBkwDIBc7e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXOzdrAAoJEKeha0olJ0Nqw6AIAIOSyBCGu8u+QfbtdJ69nzQC mYNbShIXQKXITCGkx0GAAKwz7dETynHb3vgC93ELVs1sHpZFvlVYHANnaGOgbHHP jfET6W8Xr+8pR7bUhNvJJb9VRR5TRUHbcCLLkvpy/OSSliSefRsp3zydd7mV+ESw 0LtYkpoUOL2UEJY3luH0cT6m3tdKKw55/sfjeVrKY1H8s9fj0FlU8vDmOD5q8yVD g4LHdnSkPziJd93tUCzpfFE1vOL5nYcHQmToXk22Ii/IMRx9lweGVjaW+av6RPzy 9Px27VwGRTadE75MBO/4QfTGM6zcr1HZr+7/iQjbhr9DpknGQCNld+biQ/MhNCU= =wTFz -----END PGP SIGNATURE----- --PMAWP1X3T84EOGM0aQgpALNvBkwDIBc7e--