From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2ikC-0006ub-CN for qemu-devel@nongnu.org; Tue, 17 May 2016 13:25:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2ikB-0006l4-2q for qemu-devel@nongnu.org; Tue, 17 May 2016 13:25:20 -0400 References: <1463503863-19009-1-git-send-email-kwolf@redhat.com> <1463503863-19009-2-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <573B53F9.7040709@redhat.com> Date: Tue, 17 May 2016 11:25:13 -0600 MIME-Version: 1.0 In-Reply-To: <1463503863-19009-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L7d3MX1SnGqIcA1nl7Fievpr1hTm0fwlB" Subject: Re: [Qemu-devel] [PATCH 1/3] qcow2: fix condition in is_zero_cluster List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, den@openvz.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L7d3MX1SnGqIcA1nl7Fievpr1hTm0fwlB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/17/2016 10:51 AM, Kevin Wolf wrote: > From: "Denis V. Lunev" >=20 > We should check for (res & BDRV_BLOCK_ZERO) only. The situation when we= > will have !(res & BDRV_BLOCK_DATA) and will not have BDRV_BLOCK_ZERO is= > not possible for images with bdi.unallocated_blocks_are_zero =3D=3D tru= e. >=20 > For those images where it's false, however, it can happen and we must > not consider the data zeroed then or we would corrupt the image. >=20 > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --L7d3MX1SnGqIcA1nl7Fievpr1hTm0fwlB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXO1P5AAoJEKeha0olJ0NqVFkH/0BfJAL48gwCwIxFfeqBRUyG sZk52WLsmB7+SsWBP92zOLs3q1VwKlSx5YoD6MIVFqxxS1bb3dlIFo40zjPsVTDA 7ZD/bNse3czzK3zXL3Re3FZ+0n5QAIcsRF+pvyzrr5mQ6/gd4HiyIYZzYYMAEnOs JJvEYl37w5vrTEnfxAoYuVYrxw8NNitizDLCCM3VYVlPk3ENVkFZDnRu93yxo8Um u0QRtflG5mPmXLLHNJfQYUHjKAg+l2OW9covC03dMZYseJhjPhHfYF+nbERGvtKx iSX2gLbfEc+ssqatEsp91/Of4BIHZ6WY6QBLgYUSBZFtkssjCq5opE5DQP/wws4= =PyBJ -----END PGP SIGNATURE----- --L7d3MX1SnGqIcA1nl7Fievpr1hTm0fwlB--