From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2rGn-0007Ff-Cr for qemu-devel@nongnu.org; Tue, 17 May 2016 22:31:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2rGl-0006XU-9q for qemu-devel@nongnu.org; Tue, 17 May 2016 22:31:32 -0400 References: <1463532149-11625-1-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <573BD3FC.7040605@redhat.com> Date: Tue, 17 May 2016 20:31:24 -0600 MIME-Version: 1.0 In-Reply-To: <1463532149-11625-1-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N5aGkjEB9enk2oN581PGNJ4LNMGoDtrQU" Subject: Re: [Qemu-devel] [PATCH] block: clarify error message for qmp-eject List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N5aGkjEB9enk2oN581PGNJ4LNMGoDtrQU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/17/2016 06:42 PM, John Snow wrote: > If you use HMP's eject but the CDROM tray is locked, you may get a > confusing error message informing you that the "tray isn't open." >=20 > As this is the point of eject, we can do a little better and help > clarify that the tray was locked and that it (might) open up later, > so try again. >=20 > It's not ideal, but it makes the semantics of the (legacy) eject > command more understandable to end users when they try to use it. >=20 > Signed-off-by: John Snow > --- > blockdev.c | 36 +++++++++++++++++++++++++++++------- > 1 file changed, 29 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --N5aGkjEB9enk2oN581PGNJ4LNMGoDtrQU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXO9P8AAoJEKeha0olJ0NqOBcIAIw8txBJSqH+jhgl1PFvNopQ tSIiHoi9JeDuqHCjugeZmC5D3g4yZ9qn2X/Wmj0CRCSMCH7v0AB9sOtwRvTIWek7 CUYxGQQ5Jf/S9VKINXj1khfAdN7AwYV7cDfXbLDREk49crqHpAGoo+o//R8Ah7sT Ns0VkRD8dNu+jtyvqIrnezDQ1EmA2/5b2FafJNe2//7BfyalZ1zDOQ2xwrR1jvNs u+T41/wr00SmKyUtbctSzxKkRNsPFclAz+YV6j9BEk8m2rmXL+1P7menw+hIg7kz un392cliK5MToA94frT8IMQJvtu/39isrQXDTfVcjU+VXsO0bVu6YHsrpzN9ZHo= =E5az -----END PGP SIGNATURE----- --N5aGkjEB9enk2oN581PGNJ4LNMGoDtrQU--