From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b32D9-0006RV-DS for qemu-devel@nongnu.org; Wed, 18 May 2016 10:12:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b32D8-0007sD-4P for qemu-devel@nongnu.org; Wed, 18 May 2016 10:12:31 -0400 References: <573B8085.4010706@redhat.com> <1463574448-30065-1-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <573C7846.6010306@redhat.com> Date: Wed, 18 May 2016 08:12:22 -0600 MIME-Version: 1.0 In-Reply-To: <1463574448-30065-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9ajpbg9TF70P9Amh6mU0dRM8Ux7oiar4I" Subject: Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Some more write_zeroes tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, den@openvz.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9ajpbg9TF70P9Amh6mU0dRM8Ux7oiar4I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/18/2016 06:27 AM, Kevin Wolf wrote: > This covers some more write_zeroes cases which are relevant for the > recent qcow2 optimisations that check the allocation status of the > backing file for partial cluster write_zeroes requests. >=20 > This needs to be separate from 034 because we can only support qcow2 in= > this test case for multiple reasons: We check the allocation status > after write_zeroes with 'qemu-img map' and the optimised behaviour that= > produces zero clusters is only implemented in qcow2; second, the map > command returns offsets that are qcow2 specific; and finally, we also > use 512 byte clusters which aren't supported for formats like qed. >=20 > Signed-off-by: Kevin Wolf > --- >=20 > v2: > - Some more test cases, including one suggested by Eric > - Comments in the test script that visualise each case with ASCII art Nice! > +# qcow2 specific bdrv_write_zeroes tests with backing files (complemen= ts 034) Maybe also worth a one line tweak to 034 to give a comment pointing to this file (so the two mutually reference each other), but that doesn't require a respin. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9ajpbg9TF70P9Amh6mU0dRM8Ux7oiar4I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXPHhHAAoJEKeha0olJ0NqD38H/j+gcyrqyHpEC59jY6k350cv zMJZBbvQwZVDRSs+o8hZnL2ukfMf/sqk90ZPKpA5VKgQWXw98jq1pI9cd7EV4p6f DeUuQyHAcd/m3UWzi5ojGn3bRsewJjjL2VWcwiurYGSvUKu+qdx8gYhRm8jeHLvo I/hcyEnx9lJoLsDpq+SZuVaJ1LkE4aQuJn4TQBHJjLs+8I+7kg8OsSQpO78f3sH1 ms/EnnnrG4sA/FABz5xnuVuVp6msbg9OlRlxOEK88E3mkf7SoW2LyyTlLLr2RCou yMNTCVKpTQkMlgC5G/gizODaTgMdv/UXgXg/D1XO7lkjlUUvt6tjiNd8zxClPEo= =cElB -----END PGP SIGNATURE----- --9ajpbg9TF70P9Amh6mU0dRM8Ux7oiar4I--