Re: [Qemu-devel] [PATCH] coccinelle: add g_assert_cmp* to macro file

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

On 05/18/2016 03:27 AM, Paolo Bonzini wrote:
> This helps applying semantic patches to unit tests.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  scripts/cocci-macro-file.h | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/scripts/cocci-macro-file.h b/scripts/cocci-macro-file.h
> index eceb4be..9f2e72e 100644
> --- a/scripts/cocci-macro-file.h
> +++ b/scripts/cocci-macro-file.h
> @@ -117,3 +117,9 @@ struct {                                                                \
>          type *tqe_next;       /* next element */                        \
>          type **tqe_prev;      /* address of previous next element */    \
>  }
> +
> +/* From glib */
> +#define g_assert_cmpint(a, op, b)   g_assert(a op b)
> +#define g_assert_cmpuint(a, op, b)   g_assert(a op b)

Odd indentation, compared to the other lines.

> +#define g_assert_cmphex(a, op, b)   g_assert(a op b)
> +#define g_assert_cmpstr(a, op, b)   g_assert(strcmp(a, b) op 0)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]