From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b32QG-0001mN-DL for qemu-devel@nongnu.org; Wed, 18 May 2016 10:26:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b32QE-0002X2-Fz for qemu-devel@nongnu.org; Wed, 18 May 2016 10:26:03 -0400 References: <1463550807-2750-1-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: <573C7B74.3000706@redhat.com> Date: Wed, 18 May 2016 08:25:56 -0600 MIME-Version: 1.0 In-Reply-To: <1463550807-2750-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wANhTx1SvfanJWX8XcDup4S1aMaApfdS1" Subject: Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , qemu-stable@nongnu.org, Max Reitz , jsnow@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wANhTx1SvfanJWX8XcDup4S1aMaApfdS1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/17/2016 11:53 PM, Fam Zheng wrote: > Otherwise the job is orphaned and block_job_cancel_sync in > bdrv_close_all() when quiting will hang. s/quiting/quitting/ >=20 > A simple reproducer is running blockdev-backup from null-co:// to > null-co://. Worth a qemu-iotests addition? >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Fam Zheng > --- > block/backup.c | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wANhTx1SvfanJWX8XcDup4S1aMaApfdS1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXPHt0AAoJEKeha0olJ0NqqZ8H/0Wl+j1/YZ1eaZqhC5j36UMk apJZ7wbAdawlifCAqaoQT9R0Y6DtnbCb+OU8UpO70EbLfMrZCUFb7QQXLkVfDmLb M4phaxjdOX9TRfBWR0tr3dZWWN0DP6Fh1h6OC+ppwgE/fYRs+SRG2B2/ypcWao3r pHoIWR3y/2RSbdsXLmYnqgDvSOWO1kH6nWhZthkY9rmwBtyDgQuTQYGw9EmQYBF5 tJ3wZ7RIAm5W/tm3bEcbicugrJSPnm/6N+LWS7xK1X4gfjRaCospozU8zmoIomcv QfWRJBIK4vs0Yiw6Md/dEBfyvMc/DCPV/8PFAfzF0lsveze4SfZiO41J/hhpC8U= =1HHR -----END PGP SIGNATURE----- --wANhTx1SvfanJWX8XcDup4S1aMaApfdS1--